Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property

Bartosz Golaszewski
2018-07-17T08:01:17Z

2018-07-09 10:52 GMT+02:00 Bartosz Golaszewski <brgl@bgdev.pl>:
> 2018-07-09 5:12 GMT+02:00 Chiang, AlanX <alanx.chiang@intel.com>:
>> Hi Robert,
>>
>>> -----Original Message-----
>>> From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
>>> Sent: Friday, July 6, 2018 4:24 AM
>>> To: Rob Herring <robh@kernel.org>
>>> Cc: Chiang, AlanX <alanx.chiang@intel.com>; linux-i2c@vger.kernel.org; Yeh,
>>> Andy <andy.yeh@intel.com>; sakari.ailus@linux.intel.com;
>>> andriy.shevchenko@linux.intel.com; Shevchenko, Andriy
>>> <andriy.shevchenko@intel.com>; Mani, Rajmohan
>>> <rajmohan.mani@intel.com>; andy.shevchenko@gmail.com;
>>> tfiga@chromium.org; jcliang@chromium.org; brgl@bgdev.pl;
>>> mark.rutland@arm.com; arnd@arndb.de; gregkh@linuxfoundation.org;
>>> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
>>> Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width
>>> property
>>>
>>> On Thu, 5 Jul 2018, Rob Herring wrote:
>>>
>>> > On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@intel.com wrote:
>>> > > From: Alan Chiang <alanx.chiang@intel.com>
>>> > >
>>> > > The AT24 series chips use 8-bit address by default. If some chips
>>> > > would like to support more than 8 bits, the at24 driver should be
>>> > > added the compatible field for specfic chips.
>>> > >
>>> > > Provide a flexible way to determine the addressing bits through
>>> > > address-width in this patch.
>>> > >
>>> > > Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
>>> > > Signed-off-by: Andy Yeh <andy.yeh@intel.com>
>>> > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>>> > >
>>> > > ---
>>> > > since v1:
>>> > > -- Remove the address-width field in the example.
>>> > > since v2:
>>> > > -- Remove redundant space.
>>> > > since v3:
>>> > > -- Add Acked-by.
>>> > >
>>> > > ---
>>> > > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>>> > > 1 file changed, 2 insertions(+)
>>> >
>>> > Reviewed-by: Rob Herring <robh@kernel.org>
>>>
>>> "... should be added the compatible field ..."??
>>>
>>> rday
>>
>> Maybe I should modify the sentence as below that makes it clear.
>> "The compatible field should be added in the at24.c for specific chips.".
>>
>> I quote Andy's words in patch v2:
>> "The current at24 driver has no address width support, thus, reusing same
>> (allocated) IDs (non-DT case) is hard."
>>
>> This is the reason that I submitted the patch.
>>
>> Thanks
>>
>
> Make it something like:
>
> Currently the only way to use a variant of a supported model with
> a different address width is to define a new compatible string and the
> corresponding chip data structure.
>
> Provide a flexible way to specify the size of the address pointer by
> defining a new property: address-width.
>
> Best regards,
> Bartosz Golaszewski
>
>>>
>>> --
>>>
>>> ==========================================================
>>> ==============
>>> Robert P. J. Day Ottawa, Ontario, CANADA
>>> http://crashcourse.ca/dokuwiki
>>>
>>> Twitter: http://twitter.com/rpjday
>>> LinkedIn: http://ca.linkedin.com/in/rpjday
>>> ==========================================================
>>> ==============

Hi,

I will soon be sending my pull request to Wolfram, so if you still
want that applied for 4.19 - please resend with the commit message
fixed.

Thanks,
Bart