From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v5 04/10] dt-bindings: i3c: Document core bindings Date: Wed, 11 Jul 2018 16:45:29 +0200 Message-ID: <20180711164529.3388d045@bbrezillon> References: <20180622104930.32050-1-boris.brezillon@bootlin.com> <20180622104930.32050-5-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Jonathan Corbet , "open list:DOCUMENTATION" , Greg Kroah-Hartman , Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Cyprian Wronka , Suresh Punnoose , Rafal Ciepiela , Thomas Petazzoni , Nishanth Menon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell List-Id: linux-i2c@vger.kernel.org On Wed, 11 Jul 2018 16:10:10 +0200 Arnd Bergmann wrote: > On Fri, Jun 22, 2018 at 12:49 PM, Boris Brezillon > wrote: > > A new I3C subsystem has been added and a generic description has been > > created to represent the I3C bus and the devices connected on it. > > > > > +I2C devices > > +=========== > > + > > +Each I2C device connected to the bus should be described in a subnode. All > > +properties described in Documentation/devicetree/bindings/i2c/i2c.txt are > > +valid here, but several new properties have been added. > > + > > +New constraint on existing properties: > > +-------------------------------------- > ... > > + + third cell: should be 0 > > What for? Just to be future-proof, or do you have something specific > in mind here? Even if I2C devices only need 1 cell, I3C devices need 3 (1 for the static address and 2 for the PID). Since both type of devices are described under the same bus node, and we can have different #address-cells, I had to put 0-padding in the last cell.