From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 1/5] i2c: designware: factorize setting SDA hold time Date: Tue, 17 Jul 2018 14:31:08 +0200 Message-ID: <20180717123108.GA23935@piout.net> References: <20180717114837.21839-1-alexandre.belloni@bootlin.com> <20180717114837.21839-2-alexandre.belloni@bootlin.com> <5a1846aa7c03cc889f072d1aab6967ff254b49de.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5a1846aa7c03cc889f072d1aab6967ff254b49de.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Wolfram Sang , Jarkko Nikula , James Hogan , Paul Burton , Mika Westerberg , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Thomas Petazzoni , Allan Nielsen List-Id: linux-i2c@vger.kernel.org On 17/07/2018 15:11:50+0300, Andy Shevchenko wrote: > On Tue, 2018-07-17 at 13:48 +0200, Alexandre Belloni wrote: > > Factorize setting the SDA hold time in a new function > > i2c_dw_set_sda_hold_time() that is used for both master and slave > > mode. > > > > This conveniently pulls the fix for the spurious warning from commit > > 7a20e707aae2 ("i2c: designware: suppress unneeded SDA hold time > > warnings") > > in slave mode. > > Isn't this a duplication of > > commit 1080ee7e28e1cea86310739e5dd4612868768aed > Author: Jarkko Nikula > Date: Tue Jun 19 14:23:22 2018 +0300 > > i2c: designware: Move SDA hold time configuration to common code > > ? > Indeed, I was on 4.18-rc1, not -next. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com