From: Wolfram Sang <wsa@the-dreams.de>
To: shubhrajyoti.datta@gmail.com
Cc: linux-i2c@vger.kernel.org, michal.simek@xilinx.com,
linux-kernel@vger.kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic
Date: Tue, 4 Sep 2018 18:11:14 +0200 [thread overview]
Message-ID: <20180904161114.GC5000@kunai> (raw)
In-Reply-To: <1535967671-7784-1-git-send-email-shubhrajyoti.datta@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.datta@gmail.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> Disable interrupts while configuring the transfer and enable them back.
>
> We have below as the programming sequence
> 1. start and slave address
> 2. byte count and stop
>
> In some customer platform there was a lot of interrupts between 1 and 2
> and after slave address (around 7 clock cyles) if 2 is not executed
> then the transaction is nacked.
>
> To fix this case make the 2 writes atomic.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
I assume simply changing the order of the register writes won't fix it?
I also assume this is stable material?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-04 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 9:41 [PATCH] i2c: xiic: Make the start and the byte count write atomic shubhrajyoti.datta
2018-09-04 16:11 ` Wolfram Sang [this message]
2018-09-06 7:08 ` Shubhrajyoti Datta
2018-09-06 18:52 ` Wolfram Sang
2018-09-07 6:02 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904161114.GC5000@kunai \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).