Re: [PATCH] i2c: synquacer: fix fall-through annotation

Ard Biesheuvel
2018-09-14T06:07:20Z

On 13 September 2018 at 20:59, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
> drivers/i2c/busses/i2c-synquacer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c
> index 915f5ed..2184b7c 100644
> --- a/drivers/i2c/busses/i2c-synquacer.c
> +++ b/drivers/i2c/busses/i2c-synquacer.c
> @@ -404,7 +404,7 @@ static irqreturn_t synquacer_i2c_isr(int irq, void *dev_id)
> if (i2c->state == STATE_READ)
> goto prepare_read;
>
> - /* fallthru */
> + /* fall through */
>
> case STATE_WRITE:
> if (bsr & SYNQUACER_I2C_BSR_LRB) {
> --
> 2.7.4
>