[PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter

[PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter

[Luca Ceresoli]

From: Luca Ceresoli <luca@lucaceresoli.net>

struct i2c_client has a direct pointer to the adapter, no need to dig
it out of the struct device tree.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---

Sorry for the RESEND noise, but my provider and vger are not
interacting (again). I'll solve the issue at its root ASAP, but in the
meanwhile I'm sending from a different account.

 drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 24bd9275fde5..bfabf985e830 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -347,7 +347,7 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc)
 static int pca954x_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id)
 {
-	struct i2c_adapter *adap = to_i2c_adapter(client->dev.parent);
+	struct i2c_adapter *adap = client->adapter;
 	struct pca954x_platform_data *pdata = dev_get_platdata(&client->dev);
 	struct device *dev = &client->dev;
 	struct device_node *np = dev->of_node;
-- 
2.17.1

Re: [PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter

[Peter Rosin]

On 2018-09-26 10:35, Luca Ceresoli wrote:
> From: Luca Ceresoli <luca@lucaceresoli.net>
> 
> struct i2c_client has a direct pointer to the adapter, no need to dig
> it out of the struct device tree.

Right, looks sane, but can you please also do the same thing for the
ltc4306 and mlxcpld drivers which have the same pattern?

Cheers,
Peter

> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> 
> Sorry for the RESEND noise, but my provider and vger are not
> interacting (again). I'll solve the issue at its root ASAP, but in the
> meanwhile I'm sending from a different account.
> 
>  drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index 24bd9275fde5..bfabf985e830 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -347,7 +347,7 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc)
>  static int pca954x_probe(struct i2c_client *client,
>  			 const struct i2c_device_id *id)
>  {
> -	struct i2c_adapter *adap = to_i2c_adapter(client->dev.parent);
> +	struct i2c_adapter *adap = client->adapter;
>  	struct pca954x_platform_data *pdata = dev_get_platdata(&client->dev);
>  	struct device *dev = &client->dev;
>  	struct device_node *np = dev->of_node;
> 

Re: [PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter

[Luca Ceresoli]

Hi Peter,

thanks for the review.

On 01/10/2018 13:49, Peter Rosin wrote:
> On 2018-09-26 10:35, Luca Ceresoli wrote:
>> From: Luca Ceresoli <luca@lucaceresoli.net>
>>
>> struct i2c_client has a direct pointer to the adapter, no need to dig
>> it out of the struct device tree.
> 
> Right, looks sane, but can you please also do the same thing for the
> ltc4306 and mlxcpld drivers which have the same pattern?

No problem. But be aware I can't runtime test these two drivers.

-- 
Luca