From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] eeprom: New ee1004 driver for DDR4 memory Date: Tue, 2 Oct 2018 15:27:27 -0700 Message-ID: <20181002222727.GB19204@kroah.com> References: <20180226102000.1b76640e@endymion> <20181002114346.4bcf7927@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181002114346.4bcf7927@endymion> Sender: linux-kernel-owner@vger.kernel.org To: Jean Delvare Cc: Bartosz Golaszewski , Arnd Bergmann , Linux I2C , LKML List-Id: linux-i2c@vger.kernel.org On Tue, Oct 02, 2018 at 11:43:46AM +0200, Jean Delvare wrote: > On Mon, 26 Feb 2018 14:40:42 +0100, Bartosz Golaszewski wrote: > > 2018-02-26 10:20 GMT+01:00 Jean Delvare : > > > The EEPROMs which hold the SPD data on DDR4 memory modules are no > > > longer standard AT24C02-compatible EEPROMs. They are 512-byte EEPROMs > > > which use only 1 I2C address for data access. You need to switch > > > between the lower page and the upper page of data by sending commands > > > on the SMBus. > > > > > > Signed-off-by: Jean Delvare > > > --- > > > drivers/misc/eeprom/Kconfig | 11 + > > > drivers/misc/eeprom/Makefile | 1 > > > drivers/misc/eeprom/ee1004.c | 281 +++++++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 293 insertions(+) > > > > is there any reason not to use regmap as is done currently in at24? It > > would spare you a lot of code. > > As it turns out, I don't have the time to look into this. The driver is > not exactly big, it is functional, and I would hate if someone else > would duplicate the work just because my driver is not upstream. > > So, Greg, can we just get the driver in the kernel tree as is, and if > anyone really cares about it using regmap, that person will convert the > driver later? Fine with me, but someone needs to resend it as it is no longer in my patch queue at all... thanks, greg k-h