From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: [PATCH v2 00/29] at24: remove at24_platform_data Date: Thu, 4 Oct 2018 10:35:08 -0400 Message-ID: <20181004143508.GG13299@oracle.com> References: <20180810080526.27207-1-brgl@bgdev.pl> <20180831194643.GA62862@ban.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Andrew Lunn , "open list:DOCUMENTATION" , Sekhar Nori , Bartosz Golaszewski , Srinivas Kandagatla , Linux I2C , Mauro Carvalho Chehab , Rob Herring , Florian Fainelli , Jonathan Corbet , Richard Weinberger , Bartosz Golaszewski , Brian Norris , Russell King - ARM Linux , Marek Vasut , pabeni@redhat.com, Dan Carpenter , Grygorii Strashko , David Lechner , svendev@arcx.com, Boris Brezillon , linux-mtd , linux-omap List-Id: linux-i2c@vger.kernel.org Just catching up on this thread, so please excuse any unintentional misquotes here. > > > > David: I couldn't find a place in sparc code where any ethernet device > > > > would be registered, so is there a chance that nobody is using it? > > > > > > SPARC uses a true Open Firmware implementation, so it would register > > > drivers through the CONFIG_OF infrastructure. correct > The calls are not even that old, and clearly added intentionally for sparc, > see commit ba94272d08a7 ("i40e: use eth_platform_get_mac_address()") > which added the first one. Yes, correct again. Wouldn't PPC also end up doing the same thing? See also commit c762dff24c06 (for ixgbe) - without this fix sparc systems will come up with a bogus mac address and then you end up having to manually fix this in ugly ways. --Sowmini ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/