From: Wolfram Sang <wsa@the-dreams.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Call i2c_dw_clk_rate() only when calculating timings
Date: Fri, 5 Oct 2018 13:41:27 +0200 [thread overview]
Message-ID: <20181005114127.GA5433@kunai> (raw)
In-Reply-To: <20181001114905.13766-1-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
On Mon, Oct 01, 2018 at 02:49:05PM +0300, Jarkko Nikula wrote:
> There are platforms which don't provide input clock rate but provide
> I2C timing parameters. Commit 3bd4f277274b ("i2c: designware: Call
> i2c_dw_clk_rate() only once in i2c_dw_init_master()") causes needless
> warning during probe on those platforms since i2c_dw_clk_rate(), which
> causes the warning when input clock is unknown, is called even when
> there is no need to calculate timing parameters.
>
> Fixes: 3bd4f277274b ("i2c: designware: Call i2c_dw_clk_rate() only once in i2c_dw_init_master()")
> Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: <stable@vger.kernel.org> # 4.19
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-10-05 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 11:49 [PATCH] i2c: designware: Call i2c_dw_clk_rate() only when calculating timings Jarkko Nikula
2018-10-01 13:10 ` Ard Biesheuvel
2018-10-05 11:41 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005114127.GA5433@kunai \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).