From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>, David Airlie <airlied@linux.ie>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Chris Paterson <Chris.Paterson2@renesas.com>,
dri-devel@lists.freedesktop.org,
Biju Das <biju.das@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Peter Rosin <peda@axentia.se>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] drm/bridge/sii902x: Fix EDID readback
Date: Mon, 5 Nov 2018 22:15:23 +0100 [thread overview]
Message-ID: <20181105221523.4b90c87e@bbrezillon> (raw)
In-Reply-To: <1541426208-25434-1-git-send-email-fabrizio.castro@bp.renesas.com>
Hi Fabrizio,
Thanks for working on that. I think your solution fixes the issue we had
on atmel boards [1] in a clean way (still have to find some time to
test it).
On Mon, 5 Nov 2018 13:56:48 +0000
Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
> @@ -441,6 +558,9 @@ static int sii902x_remove(struct i2c_client *client)
> {
> struct sii902x *sii902x = i2c_get_clientdata(client);
>
> + if (sii902x->i2cmux)
> + i2c_mux_del_adapters(sii902x->i2cmux);
> +
Just one tiny detail: I think you can safely call i2c_mux_del_adapters()
unconditionally since ->remove() will only be called if ->probe()
succeeded, which guarantees that sii902x->i2cmux != NULL.
> drm_bridge_remove(&sii902x->bridge);
>
> return 0;
[1]https://patchwork.kernel.org/patch/9532005/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-05 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 13:56 [PATCH v2] drm/bridge/sii902x: Fix EDID readback Fabrizio Castro
2018-11-05 21:15 ` Boris Brezillon [this message]
2018-11-06 10:25 ` Fabrizio Castro
2018-11-05 22:34 ` Peter Rosin
2018-11-06 10:29 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105221523.4b90c87e@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Chris.Paterson2@renesas.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=biju.das@bp.renesas.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox