From: Sasha Levin <sashal@kernel.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: stable@vger.kernel.org, Alan Chiang <alanx.chiang@intel.com>,
Andy Yeh <andy.yeh@intel.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-i2c@vger.kernel.org
Subject: Re: 4.14/4.18: Please add "eeprom: at24: Add support for address-width property"
Date: Mon, 5 Nov 2018 18:51:21 -0500 [thread overview]
Message-ID: <20181105235121.GW194472@sasha-vm> (raw)
In-Reply-To: <20181031204959.GA3691@localhost>
On Wed, Oct 31, 2018 at 10:49:59PM +0200, Adrian Bunk wrote:
>On Wed, Oct 31, 2018 at 10:27:45AM -0400, Sasha Levin wrote:
>> On Mon, Oct 22, 2018 at 11:38:35AM +0300, Adrian Bunk wrote:
>> > Please cherry-pick the following commit to 4.14 and 4.18:
>> >
>> > commit a2b3bf4846e5eed62ea6abb096af2c950961033c
>> > Author: Alan Chiang <alanx.chiang@intel.com>
>> > Date: Wed Jul 25 11:20:22 2018 +0800
>> >
>> > eeprom: at24: Add support for address-width property
>> >
>> > Provide a flexible way to determine the addressing bits of eeprom.
>> > Pass the addressing bits to driver through address-width property.
>> >
>> > Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
>> > Signed-off-by: Andy Yeh <andy.yeh@intel.com>
>> > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
>> >
>> >
>> > Confirmed to work on 4.14 with the Identification Page
>> > of an ST M24M02-DR (256 bytes but 16 bit addressing).
>>
>> This patch doesn't look like stable material. The hardware never worked
>> before, so this is not a regression and falls under new hardware
>> enablement, but the patch is more complex than what we usually allow for
>> hardware enablement (adding various IDs/quirks/etc).
>>
>> Am I missing something?
>
>IMHO it is a pretty straightforward quirk for hardware enablement.
>
>Note that the quirk will only be used if explicitely enabled in the
>device tree, for everyone else this code is a nop.
Fair enough. I've queued it for 4.18 and 4.14.
next prev parent reply other threads:[~2018-11-05 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 8:38 4.14/4.18: Please add "eeprom: at24: Add support for address-width property" Adrian Bunk
2018-10-31 14:27 ` Sasha Levin
2018-10-31 20:49 ` Adrian Bunk
2018-11-05 23:51 ` Sasha Levin [this message]
2018-11-05 10:08 ` Yeh, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105235121.GW194472@sasha-vm \
--to=sashal@kernel.org \
--cc=alanx.chiang@intel.com \
--cc=andy.yeh@intel.com \
--cc=brgl@bgdev.pl \
--cc=bunk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).