From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core Date: Wed, 12 Dec 2018 00:41:03 +0100 Message-ID: <20181211234102.GA6701@kunai> References: <20181210210310.12677-1-wsa+renesas@sang-engineering.com> <2094a0d4-733f-7f74-abd2-bdb28edd0f80@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Return-path: Content-Disposition: inline In-Reply-To: <2094a0d4-733f-7f74-abd2-bdb28edd0f80@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org List-Id: linux-i2c@vger.kernel.org --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Hans, thanks for testing this series! > Note that the i2c-sprd driver changes in your patchset also get close > to triggering this problem, but they dodge the bullet because there > are separate system-wide and runtime suspend handlers and only the > system-wide handlers call the new i2c_mark_adapter_suspended() function. Yes, this what I assumed to be all around - seperate handlers for RPM and PM. And I also assumed that they could be seperated if they aren't already. Until I read... > As I explain in the commit message of the first attached patch > simply always using split handlers is not really an option because > of adapter drivers using DPM_FLAG_SMART_PREPARE or > DPM_FLAG_SMART_SUSPEND. ... this. I don't know what these flags do (and reading SMART in there gives me more a 'uh-oh' feeling) but if the handlers can't be split, the issues you were seeing are a consequence, yes. For me, this sadly spoils the whole concept. The patches you add make things even more complicated. Not happy about that. Looking at the open coded version you did for the designware driver, I wonder now if it is better to just leave it at driver level? Need to sleep over it, though. Thanks again, Wolfram --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlwQSwoACgkQFA3kzBSg KbZaWhAAqL4UJf4q20FrE3tk+nfMGtcTU2zNWCwJpJFXNnbUYjRE77mFF6PuBym/ CUMjKU6iKIF30DpsJFPgf1/fPnNQJy2+qM4X7oSjZfLE31sp7WMtx4juxX3GV0+E +hVGNP4qkwytLwEz+bo4kAkBoRIszttFRKcE5Zur706OwlSh/DzVWYAgiKsA65aW jueC7gS9FB3/4X9LfZAiKWi88NVa2DeL5l19N/uWxkfW3zNxO8u5J6x+ihqGuGXx Sjf6gpMq9gV9WaBQtZnRSbuNNaGB3D0gmcEhShBAYmYwQBBIUVFzBlJoZnO6rhRr lrYxym0dqgH2szh23QFwta/4qGKAbc3yyAsxh4brsAtkv7P4MgCYrNtRJhdq3LIV qEZG7V4QFzYmdi+1dJdvc5nDxsRH3ijBMZf45884GXUxIhSpnh9qqEeOzGs94nc+ GoU+TSbNrznuTy77P3KuQfnaiY+KQVLTZi10zN2UuZbIUFLOxOSD/dRQo7zDju+1 PaKKXYh0q8Z5JmYTXqlFgBUo2zd3W0gvOWo+SNVSuFchVzg8XQSC1xTv/0UO45us H96p+HZNmbuFIBsz04VpkLy49+YEb7F7bRFQuqkrQlnMVnUDfvcbAHseCIohonN4 RZv0M6iFGj5kObRiCJOqlacQbuT4XOdikuJDgaCBinPXCNGUoWE= =L8ZM -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5--