From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-i2c@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v4 2/2] i2c: imx: forward error values out of i2c_imx_dma_request()
Date: Mon, 7 Jan 2019 21:31:27 +0100 [thread overview]
Message-ID: <20190107203127.6hifb7ilugkiaxpt@pengutronix.de> (raw)
In-Reply-To: <20190107084738.4130-3-o.rempel@pengutronix.de>
On Mon, Jan 07, 2019 at 09:47:38AM +0100, Oleksij Rempel wrote:
> Make sure, i2c_imx_probe() well get and forward same error values as
> i2c_imx_dma_request().
Maybe better: Improve the error handling in i2c_imx_dma_request() and
let it return an error indication that the caller then can handle
accordingly.
> -static void i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
> +static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
> dma_addr_t phy_addr)
This is a good opportunity to realign the continuation line to the
opening parenthesis.
Otherwise the patch looks good.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2019-01-07 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 8:47 [PATCH v4 0/2] i2c: imx: rework imx error handling Oleksij Rempel
2019-01-07 8:47 ` [PATCH v4 1/2] i2c: imx: notify about real errors on dma i2c_imx_dma_request Oleksij Rempel
2019-01-07 20:27 ` Uwe Kleine-König
2019-01-07 8:47 ` [PATCH v4 2/2] i2c: imx: forward error values out of i2c_imx_dma_request() Oleksij Rempel
2019-01-07 20:31 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107203127.6hifb7ilugkiaxpt@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).