From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v4 2/2] i2c: imx: forward error values out of i2c_imx_dma_request() Date: Mon, 7 Jan 2019 21:31:27 +0100 Message-ID: <20190107203127.6hifb7ilugkiaxpt@pengutronix.de> References: <20190107084738.4130-1-o.rempel@pengutronix.de> <20190107084738.4130-3-o.rempel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20190107084738.4130-3-o.rempel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Oleksij Rempel Cc: Wolfram Sang , Sascha Hauer , linux-i2c@vger.kernel.org, Pengutronix Kernel Team , Fabio Estevam , Shawn Guo , linux-arm-kernel@lists.infradead.org, NXP Linux Team List-Id: linux-i2c@vger.kernel.org On Mon, Jan 07, 2019 at 09:47:38AM +0100, Oleksij Rempel wrote: > Make sure, i2c_imx_probe() well get and forward same error values as > i2c_imx_dma_request(). Maybe better: Improve the error handling in i2c_imx_dma_request() and let it return an error indication that the caller then can handle accordingly. > -static void i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, > +static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, > dma_addr_t phy_addr) This is a good opportunity to realign the continuation line to the opening parenthesis. Otherwise the patch looks good. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ |