linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Elie Morisse <syniurge@gmail.com>,
	linux-i2c <linux-i2c@vger.kernel.org>,
	Nehal-bakulchandra.Shah@amd.com, Shyam-sundar.S-k@amd.com,
	sandeep.singh@amd.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH v15] i2c: Add drivers for the AMD PCIe MP2 I2C controller
Date: Thu, 7 Feb 2019 16:53:27 +0100	[thread overview]
Message-ID: <20190207155326.GC4796@kunai> (raw)
In-Reply-To: <CAErSpo5kvFVwo-DCLYT_7UmRQKS1jHahFXawvnZUtZ=ApHKz1Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi Bjorn,

thanks a lot for your additional information!

> IMHO the split into two drivers is a bit of a mess and doesn't really
> correspond with the hardware, as I mentioned at [1].  The PCI device
> is the real hardware and the driver should claim that.  AFAICT the
> ACPI device exists only to pass some config information to the PCI
> driver.  I think the natural approach would be for the PCI driver to
> directly search the ACPI namespace for that config information.

AFAIR the AMD folks insisted on the two driver setup because they need
it in the future? Maybe they can explain again here?

> The fact that driver_find_device() is essentially unused except for a
> few very special cases is a good clue that there's probably a better
> way.

Excactly this thinking made me recommend something else, too. Let's see
what we can come up with.

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-02-07 15:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26 23:22 [PATCH v15] i2c: Add drivers for the AMD PCIe MP2 I2C controller Elie Morisse
2018-12-28 19:17 ` Elie Morisse
2018-12-28 19:57   ` Wolfram Sang
2018-12-31 14:36 ` Shah, Nehal-bakulchandra
2019-01-24  4:26   ` Kai-Heng Feng
2019-01-24  5:42     ` Wolfram Sang
2019-02-05 12:05 ` Wolfram Sang
2019-02-05 19:57   ` Bjorn Helgaas
2019-02-07 15:53     ` Wolfram Sang [this message]
2019-02-07 16:47       ` Shah, Nehal-bakulchandra
2019-02-07 17:29         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207155326.GC4796@kunai \
    --to=wsa@the-dreams.de \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeep.singh@amd.com \
    --cc=syniurge@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).