From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: Federico Vaga <federico.vaga@cern.ch>,
Peter Korsgaard <peter@korsgaard.com>,
Andrew Lunn <andrew@lunn.ch>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 5/5] i2c:ocores: checkpatch fixes
Date: Mon, 11 Feb 2019 11:26:50 +0100 [thread overview]
Message-ID: <20190211102649.pixedc2d4u3imoud@ninjato> (raw)
In-Reply-To: <fd5b5044-2415-c52c-ecb0-1f0f38267355@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
> > /* Read and write functions for the GRLIB port of the controller. Registers are
> > * 32-bit big endian and the PRELOW and PREHIGH registers are merged into one
> > - * register. The subsequent registers has their offset decreased accordingly. */
> > + * register. The subsequent registers has their offset decreased accordingly.
> > + */
>
> The preferred multi-line comment styles is:
>
> /*
> * Read...
> * ...accordingly.
> */
>
> So, please fix all issues when you are changing it to conform.
Yes. It is enough to send this updated patch alone; I applied the rest
already.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-11 10:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 8:31 [PATCH v4 0/5] i2c:ocores: improvements Federico Vaga
2019-02-11 8:31 ` [PATCH v4 1/5] i2c:ocores: stop transfer on timeout Federico Vaga
2019-02-11 10:24 ` Wolfram Sang
2019-02-11 14:01 ` Andrew Lunn
2019-02-11 14:34 ` Federico Vaga
2019-02-11 14:53 ` Wolfram Sang
2019-02-11 10:44 ` Peter Rosin
2019-02-11 13:02 ` Federico Vaga
2019-02-11 8:31 ` [PATCH v4 2/5] i2c:ocores: do not handle IRQ if IF is not set Federico Vaga
2019-02-11 10:24 ` Wolfram Sang
2019-02-11 8:31 ` [PATCH v4 3/5] i2c:ocores: add polling interface Federico Vaga
2019-02-11 10:25 ` Wolfram Sang
2019-02-11 13:47 ` Federico Vaga
2019-02-11 10:43 ` Peter Rosin
2019-02-11 13:14 ` Federico Vaga
2019-02-11 13:35 ` Peter Rosin
2019-02-11 13:46 ` Federico Vaga
2019-02-11 8:31 ` [PATCH v4 4/5] i2c:ocores: add SPDX tag Federico Vaga
2019-02-11 10:25 ` Wolfram Sang
2019-02-11 8:31 ` [PATCH v4 5/5] i2c:ocores: checkpatch fixes Federico Vaga
2019-02-11 10:16 ` Peter Rosin
2019-02-11 10:26 ` Wolfram Sang [this message]
2019-02-11 10:28 ` Peter Rosin
2019-02-11 10:52 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211102649.pixedc2d4u3imoud@ninjato \
--to=wsa@the-dreams.de \
--cc=andrew@lunn.ch \
--cc=federico.vaga@cern.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox