From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: Federico Vaga <federico.vaga@cern.ch>,
Peter Korsgaard <peter@korsgaard.com>,
Andrew Lunn <andrew@lunn.ch>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 5/5] i2c:ocores: checkpatch fixes
Date: Mon, 11 Feb 2019 17:19:43 +0100 [thread overview]
Message-ID: <20190211161942.ckuys4vyagbwaklq@ninjato> (raw)
In-Reply-To: <bbaaa303-75f1-9272-c01f-914175237f05@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
> > - oc_setreg(i2c, OCI2C_CONTROL, ctrl & ~(OCI2C_CTRL_EN|OCI2C_CTRL_IEN));
> > + ctrl = oc_getreg(i2c, OCI2C_CONTROL);
>
> There's a pointless double oc_getreg(i2c, OCI2C_CONTROL).
In case you need to resend, please update $subject of all patches to
have a space after "i2c:"
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-02-11 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 16:05 [PATCH v5 0/5] i2c:ocores: improvements Federico Vaga
2019-02-11 16:05 ` [PATCH v5 1/5] i2c:ocores: stop transfer on timeout Federico Vaga
2019-02-11 16:05 ` [PATCH v5 2/5] i2c:ocores: do not handle IRQ if IF is not set Federico Vaga
2019-02-11 16:05 ` [PATCH v5 3/5] i2c:ocores: add polling interface Federico Vaga
2019-02-11 16:05 ` [PATCH v5 4/5] i2c:ocores: add SPDX tag Federico Vaga
2019-02-11 16:05 ` [PATCH v5 5/5] i2c:ocores: checkpatch fixes Federico Vaga
2019-02-11 16:12 ` Peter Rosin
2019-02-11 16:18 ` Federico Vaga
2019-02-11 16:19 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211161942.ckuys4vyagbwaklq@ninjato \
--to=wsa@the-dreams.de \
--cc=andrew@lunn.ch \
--cc=federico.vaga@cern.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox