From: Wolfram Sang <wsa@the-dreams.de>
To: John Sperbeck <jsperbeck@google.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, rostedt@goodmis.org
Subject: Re: [PATCH v3] i2c: core-smbus: don't trace smbus_reply data on errors
Date: Thu, 14 Feb 2019 18:02:30 +0100 [thread overview]
Message-ID: <20190214170230.dvm4i2wxmgxij4bg@ninjato> (raw)
In-Reply-To: <20190213034057.244716-1-jsperbeck@google.com>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Tue, Feb 12, 2019 at 07:40:57PM -0800, John Sperbeck wrote:
> If an smbus transfer fails, there's no guarantee that the output
> buffer was written. So, avoid trying to show the output buffer when
> tracing after an error. This was 'mostly harmless', but would trip
> up kasan checking if left-over cruft in byte 0 is a large length,
> causing us to read from unwritten memory.
>
> Signed-off-by: John Sperbeck <jsperbeck@google.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-02-14 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 3:40 [PATCH v3] i2c: core-smbus: don't trace smbus_reply data on errors John Sperbeck
2019-02-13 13:50 ` Steven Rostedt
2019-02-14 17:02 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214170230.dvm4i2wxmgxij4bg@ninjato \
--to=wsa@the-dreams.de \
--cc=jsperbeck@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox