From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Dave Gerlach <d-gerlach@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Keerthy <j-keerthy@ti.com>, Tero Kristo <t-kristo@ti.com>,
letux-kernel@openphoenux.org
Subject: Re: [PATCH] mfd: twl-core: disable irq while suspended
Date: Sat, 23 Feb 2019 10:23:23 -0800 [thread overview]
Message-ID: <20190223182323.GA39872@atomide.com> (raw)
In-Reply-To: <20190223114754.16286-1-andreas@kemnade.info>
* Andreas Kemnade <andreas@kemnade.info> [190223 11:48]:
> Since commit
> 6e2bd956936 ("i2c: omap: Use noirq system sleep pm ops to idle device for suspend")
> on gta04 we have handle_twl4030_pih() called in situations where pm_runtime_get()
> in i2c-omap.c returns -EACCES.
> [ 86.474365] Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done.
> [ 86.485473] printk: Suspending console(s) (use no_console_suspend to debug)
> [ 86.555572] Disabling non-boot CPUs ...
> [ 86.555664] Successfully put all powerdomains to target state
> [ 86.563720] twl: Read failed (mod 1, reg 0x01 count 1)
> [ 86.563751] twl4030: I2C error -13 reading PIH ISR
> [ 86.563812] twl: Read failed (mod 1, reg 0x01 count 1)
> [ 86.563812] twl4030: I2C error -13 reading PIH ISR
> [ 86.563873] twl: Read failed (mod 1, reg 0x01 count 1)
> [ 86.563903] twl4030: I2C error -13 reading PIH ISR
>
> This happens when we wakeup via something behing twl4030
> (powerbutton or rtc alarm).
> This goes on for minutes until the system is finally resumed.
> Disable the irq on suspend and enable it on resume to avoid
> having i2c access problems when the irq registers are checked.
Thanks for fixing this, still works fine for me for rtcwake:
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2019-02-23 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 11:47 [PATCH] mfd: twl-core: disable irq while suspended Andreas Kemnade
2019-02-23 18:23 ` Tony Lindgren [this message]
2019-03-01 6:45 ` Andreas Kemnade
2019-04-02 3:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223182323.GA39872@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=d-gerlach@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).