From: kbuild test robot <lkp@intel.com>
To: Elie Morisse <syniurge@gmail.com>
Cc: kbuild-all@01.org, linux-i2c@vger.kernel.org,
Wolfram Sang <wsa@the-dreams.de>,
Nehal-bakulchandra.Shah@amd.com, Shyam-sundar.S-k@amd.com,
sandeep.singh@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16] i2c: Add drivers for the AMD PCIe MP2 I2C controller
Date: Thu, 28 Feb 2019 00:00:30 +0800 [thread overview]
Message-ID: <201902272334.tadrCx4p%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190226161243.GA21539@syn-yoga530>
[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]
Hi Elie,
I love your patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v5.0-rc8 next-20190227]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Elie-Morisse/i2c-Add-drivers-for-the-AMD-PCIe-MP2-I2C-controller/20190227-225657
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-8 (Debian 8.2.0-21) 8.2.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/i2c/busses/i2c-amd-mp2-pci.c: In function 'amd_mp2_rw':
>> drivers/i2c/busses/i2c-amd-mp2-pci.c:105:3: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
writeq((u64)i2c_common->dma_addr,
^~~~~~
writel
cc1: some warnings being treated as errors
vim +105 drivers/i2c/busses/i2c-amd-mp2-pci.c
88
89 int amd_mp2_rw(struct amd_i2c_common *i2c_common, enum i2c_cmd reqcmd)
90 {
91 struct amd_mp2_dev *privdata = i2c_common->mp2_dev;
92 union i2c_cmd_base i2c_cmd_base;
93
94 amd_mp2_cmd_rw_fill(i2c_common, &i2c_cmd_base, reqcmd);
95 amd_mp2_c2p_mutex_lock(i2c_common);
96
97 if (i2c_common->msg->len <= 32) {
98 i2c_cmd_base.s.mem_type = use_c2pmsg;
99 if (reqcmd == i2c_write)
100 memcpy_toio(privdata->mmio + AMD_C2P_MSG2,
101 i2c_common->msg->buf,
102 i2c_common->msg->len);
103 } else {
104 i2c_cmd_base.s.mem_type = use_dram;
> 105 writeq((u64)i2c_common->dma_addr,
106 privdata->mmio + AMD_C2P_MSG2);
107 }
108
109 return amd_mp2_cmd(i2c_common, i2c_cmd_base);
110 }
111 EXPORT_SYMBOL_GPL(amd_mp2_rw);
112
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66575 bytes --]
prev parent reply other threads:[~2019-02-27 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 16:12 [PATCH v16] i2c: Add drivers for the AMD PCIe MP2 I2C controller Elie Morisse
2019-02-26 16:23 ` Elie Morisse
2019-02-26 16:50 ` Wolfram Sang
2019-02-28 9:56 ` Shah, Nehal-bakulchandra
2019-02-28 10:12 ` Wolfram Sang
2019-02-27 16:00 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201902272334.tadrCx4p%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=kbuild-all@01.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeep.singh@amd.com \
--cc=syniurge@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox