From: Wolfram Sang <wsa@the-dreams.de>
To: Elie Morisse <syniurge@gmail.com>
Cc: linux-i2c@vger.kernel.org, Nehal-bakulchandra.Shah@amd.com,
Shyam-sundar.S-k@amd.com, sandeep.singh@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v17] i2c: Add drivers for the AMD PCIe MP2 I2C controller
Date: Mon, 25 Mar 2019 15:37:52 +0100 [thread overview]
Message-ID: <20190325143752.GA4456@kunai> (raw)
In-Reply-To: <20190305151319.GA22819@syn-yoga530>
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
On Tue, Mar 05, 2019 at 12:13:19PM -0300, Elie Morisse wrote:
> MP2 controllers have two separate busses, so may accommodate up to two I2C
> adapters. Those adapters are listed in the ACPI namespace with the
> "AMDI0011" HID, and probed by a platform driver.
>
> Communication with the MP2 takes place through MMIO registers, or through
> DMA for more than 32 bytes transfers.
>
> This is major rework of the patch submitted by Nehal-bakulchandra Shah from
> AMD (https://patchwork.kernel.org/patch/10597369/).
>
> Most of the event handling of v3 was rewritten to make it work with more
> than one bus (e.g on Ryzen-based Lenovo Yoga 530), and this version
> contains many other improvements.
>
> Signed-off-by: Elie Morisse <syniurge@gmail.com>
OK, there are still some parts I am not exactly happy with (e.g. the
find/match_device mechanism), but the driver seems to work and I don't
see major blockers anymore. The remaining issues can be fixed
incrementally. Hopefully the driver will become more visible now.
Applied to for-next, thanks everyone, especially Elie!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-25 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 15:13 [PATCH v17] i2c: Add drivers for the AMD PCIe MP2 I2C controller Elie Morisse
2019-03-21 8:37 ` Shah, Nehal-bakulchandra
2019-03-25 14:37 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325143752.GA4456@kunai \
--to=wsa@the-dreams.de \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeep.singh@amd.com \
--cc=syniurge@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).