Re: [RFC PATCH] i2c: remove use of in_atomic()

Peter Zijlstra
2019-04-01T11:21:09Z

On Mon, Apr 01, 2019 at 01:13:24PM +0200, Wolfram Sang wrote:

> > Why must we allow i2c usage with IRQs disabled? Just say NO?
>
> I'd love to. But quoting my patch description:
>
> "This matches the use cases for atomic I2C transfers I have seen so far:
> very late communication (mostly to a PMIC) to powerdown or reboot the
> system."

Ah, sorry, I missed that.

> And yes, I would never recommend a HW design to use I2C for shutting
> down/rebooting. But such HW is out there.

Can we then make the whole thing conditional on:

system_state > SYSTEM_RUNNING

Such that we're sure to never trigger this under any other conditions?