From: Wolfram Sang <wsa@the-dreams.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mukesh Ojha <mojha@codeaurora.org>
Subject: Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include
Date: Mon, 1 Apr 2019 16:08:06 +0200 [thread overview]
Message-ID: <20190401140806.GB4570@kunai> (raw)
In-Reply-To: <CAErSpo6_VMJ8nP9sA2xZffsMXdG3bKKv8WL0skyTTbuLe4WtJQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> > <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
> > convert i2c-isch to platform_device") removed the use of
> > acpi_check_region() but not the include.
> >
> > Remove the now-unnecessary include of <linux/acpi.h>. No functional change
> > intended.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Added
>
> Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>
> on my local branch.
>
> Jean, would you like me to repost this with the updates? I assume you
> will merge this (just based on get_maintainer.pl)?
I will apply it, now that it has Jean's Rev-by. I assume this is
for-next material despite the Fixes tag?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-04-01 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 18:36 [PATCH] i2c: isch: Remove unnecessary acpi.h include helgaas
2019-03-31 8:36 ` Jean Delvare
2019-03-31 9:31 ` Mukesh Ojha
2019-04-01 13:50 ` Bjorn Helgaas
2019-04-01 14:08 ` Wolfram Sang [this message]
2019-04-01 19:37 ` Bjorn Helgaas
2019-04-01 19:45 ` Wolfram Sang
2019-04-03 20:57 ` Wolfram Sang
2019-04-03 22:27 ` Bjorn Helgaas
2019-04-01 15:07 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401140806.GB4570@kunai \
--to=wsa@the-dreams.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).