From: Serge Semin <fancer.lancer@gmail.com>
To: Peter Korsgaard <peter.korsgaard@barco.com>,
Peter Rosin <peda@axentia.se>
Cc: Serge Semin <Sergey.Semin@t-platforms.ru>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] i2c-mux-gpio: Split plat- and dt-specific code up
Date: Fri, 26 Apr 2019 02:20:25 +0300 [thread overview]
Message-ID: <20190425232028.9333-1-fancer.lancer@gmail.com> (raw)
In-Reply-To: <20190424123414.25311-1-fancer.lancer@gmail.com>
The main idea of this patchset was to add the full dt GPIOs specifier
support in i2c-mux-gpio driver. In particular we needed to have the
full GPIOs specifier being handled including the flags like GPIO_ACTIVE_HIGH,
GPIO_ACTIVE_LOW, GPIO_PUSH_PULL, GPIO_OPEN_DRAIN or GPIO_OPEN_SOURCE.
Due to using a legacy GPIO interface the former driver implementation
didn't provide this ability.
On the way of adding the full dt-GPIO flags support a small set of
refactorings has been done in order to keep the platform_data-based
systems support, make the code more readable and the alterations - clearer.
In general the whole changes might be considered as the plat- and dt-
specific code split up. In the first patch we unpinned the platform-specific
method of GPIO-chip probing. The second patch introduces a new initial_state
value field into the "gpiomux" structure. The third one is responsible for
GPIO request loop isoltaing into a dedicated function. At this stage common
it is a common function for both dt- and plat- code paths. Finally last
patch introduces a full dt-based GPIOs request method, which uses
gpiod_get_from_of_node() method in order to parse the corresponding dt GPIO
specifiers with their falgs. The last patch does what we inteded this patchset
for in the first place - adds the full dt-GPIO specifiers support.
Changelog v2
- Remove fallback pattern when selecting the dt- or plat-based code paths.
(Cause the patch "i2c-mux-gpio: Return an error if no onfig data found"
removal.)
- Use a dedicated initial_state variable to keep the initial channels selector
state. (Causes the patch "i2c-mux-gpio: Save initial channel number to the
idle" removal.)
- Mention open-drain, open-source flags in the patchset descriptions.
Serge Semin (3):
i2c-mux-gpio: Unpin a platform-based device initialization
i2c-mux-gpio: Unpin the platform-specific GPIOs request code
i2c-mux-gpio: Create of-based GPIOs request method
drivers/i2c/muxes/i2c-mux-gpio.c | 226 ++++++++++++++++++++-----------
1 file changed, 146 insertions(+), 80 deletions(-)
--
2.21.0
next prev parent reply other threads:[~2019-04-25 23:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 12:34 [PATCH 0/5] i2c-mux-gpio: Split plat- and dt-specific code up Serge Semin
2019-04-24 12:34 ` [PATCH 1/5] i2c-mux-gpio: Unpin a platform-based device initialization Serge Semin
2019-04-24 12:34 ` [PATCH 2/5] i2c-mux-gpio: Return an error if no config data found Serge Semin
2019-04-24 21:25 ` Peter Rosin
2019-04-25 15:47 ` Serge Semin
2019-04-25 19:28 ` Peter Rosin
2019-04-25 20:09 ` Serge Semin
2019-04-24 12:34 ` [PATCH 3/5] i2c-mux-gpio: Save initial channel number to the idle data field Serge Semin
2019-04-24 21:26 ` Peter Rosin
2019-04-25 15:53 ` Serge Semin
2019-04-25 19:32 ` Peter Rosin
2019-04-24 12:34 ` [PATCH 4/5] i2c-mux-gpio: Unpin the platform-specific GPIOs request code Serge Semin
2019-04-24 12:34 ` [PATCH 5/5] i2c-mux-gpio: Create of-based GPIOs request method Serge Semin
2019-04-24 21:27 ` Peter Rosin
2019-04-24 21:25 ` [PATCH 0/5] i2c-mux-gpio: Split plat- and dt-specific code up Peter Rosin
2019-04-25 14:37 ` Serge Semin
2019-04-25 19:21 ` Peter Rosin
2019-04-25 20:03 ` Serge Semin
2019-04-25 23:20 ` Serge Semin [this message]
2019-04-25 23:20 ` [PATCH v2 1/3] i2c-mux-gpio: Unpin a platform-based device initialization Serge Semin
2019-06-09 20:51 ` Peter Rosin
2019-04-25 23:20 ` [PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code Serge Semin
2019-06-09 21:34 ` Peter Rosin
2019-06-14 16:31 ` Serge Semin
2019-06-14 18:04 ` Peter Rosin
2019-06-14 21:58 ` Serge Semin
2019-04-25 23:20 ` [PATCH v2 3/3] i2c-mux-gpio: Create of-based GPIOs request method Serge Semin
2019-05-07 9:02 ` [PATCH v2 0/3] i2c-mux-gpio: Split plat- and dt-specific code up Serge Semin
2019-05-07 9:17 ` Peter Rosin
2019-05-07 9:46 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425232028.9333-1-fancer.lancer@gmail.com \
--to=fancer.lancer@gmail.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).