From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Ruslan Babayev <ruslan@babayev.com>
Cc: wsa@the-dreams.de, linux@armlinux.org.uk, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
xe-linux-external@cisco.com
Subject: Re: [net-next,v3 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems
Date: Tue, 28 May 2019 13:42:08 +0300 [thread overview]
Message-ID: <20190528104208.GE2781@lahna.fi.intel.com> (raw)
In-Reply-To: <20190528032213.19839-3-ruslan@babayev.com>
On Mon, May 27, 2019 at 08:22:13PM -0700, Ruslan Babayev wrote:
> + } else if (ACPI_COMPANION(&pdev->dev)) {
You can also use has_acpi_companion() here.
> + struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);
> + struct fwnode_handle *fw = acpi_fwnode_handle(adev);
> + struct fwnode_reference_args args;
> + struct acpi_handle *acpi_handle;
> + int ret;
> +
> + ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
> + if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
> + dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
> + return -ENODEV;
> }
> +
> + acpi_handle = ACPI_HANDLE_FWNODE(args.fwnode);
> + i2c = i2c_acpi_find_adapter_by_handle(acpi_handle);
> + }
> +
> + if (!i2c)
> + return -EPROBE_DEFER;
> +
> + err = sfp_i2c_configure(sfp, i2c);
> + if (err < 0) {
> + i2c_put_adapter(i2c);
> + return err;
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2019-05-28 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 3:22 [net-next,v3 0/2] Enable SFP on ACPI based systems Ruslan Babayev
2019-05-28 3:22 ` [net-next,v3 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle Ruslan Babayev
2019-05-28 10:39 ` Mika Westerberg
2019-05-28 3:22 ` [net-next,v3 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems Ruslan Babayev
2019-05-28 10:42 ` Mika Westerberg [this message]
2019-05-28 10:53 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528104208.GE2781@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=ruslan@babayev.com \
--cc=wsa@the-dreams.de \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).