From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 3/8] pinctrl: msm: Add ability for drivers to supply a reserved GPIO list Date: Fri, 7 Jun 2019 21:10:44 -0700 Message-ID: <20190608041044.GK24059@builder> References: <20190605114302.22509-1-lee.jones@linaro.org> <20190605114302.22509-3-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Linus Walleij Cc: Felipe Balbi , Wolfram Sang , Greg KH , "open list:GPIO SUBSYSTEM" , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" , David Brown , alokc@codeaurora.org, linux-i2c@vger.kernel.org, MSM , Andy Gross , jlhugo@gmail.com, Lee Jones , Linux ARM List-Id: linux-i2c@vger.kernel.org On Fri 07 Jun 16:02 PDT 2019, Linus Walleij wrote: > On Wed, Jun 5, 2019 at 1:43 PM Lee Jones wrote: > = > > When booting MSM based platforms with Device Tree or some ACPI > > implementations, it is possible to provide a list of reserved pins > > via the 'gpio-reserved-ranges' and 'gpios' properties respectively. > > However some ACPI tables are not populated with this information, > > thus it has to come from a knowledgable device driver instead. > > > > Here we provide the MSM common driver with additional support to > > parse this informtion and correctly populate the widely used > > 'valid_mask'. > > > > Signed-off-by: Lee Jones > = > Exactly how we should use of the API, so if Bj=F6rn can supply an > ACK to patches 3 and 4 I'm happy to apply them. > = > Bj=F6rn? > = I'm waiting for a version that does not specify the reserved_gpios for struct msm_pinctrl_soc_data sdm845_pinctrl {}, as this would override the ability of getting these from DT. I haven't seen such revision yet, will review it once I find it. Regards, Bjorn