linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: wsa@the-dreams.de, mika.westerberg@linux.intel.com
Cc: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
	linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com,
	jbroadus@gmail.com, patches@opensource.cirrus.com
Subject: [PATCH v6 5/7] i2c: core: Move ACPI IRQ handling to probe time
Date: Fri, 21 Jun 2019 11:08:13 +0100	[thread overview]
Message-ID: <20190621100815.12417-6-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20190621100815.12417-1-ckeepax@opensource.cirrus.com>

Bring the ACPI path in sync with the device tree path and handle all the
IRQ fetching at probe time. This leaves the only IRQ handling at device
registration time being that which is passed directly through the board
info as either a resource or an actual IRQ number.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Changes since v5:
 - Pass a struct device rather than acpi_device to i2c_acpi_get_irq.

Thanks,
Charles

 drivers/i2c/i2c-core-acpi.c | 7 +------
 drivers/i2c/i2c-core-base.c | 5 ++++-
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
index 37bf80b35365f..aaca1e216be66 100644
--- a/drivers/i2c/i2c-core-acpi.c
+++ b/drivers/i2c/i2c-core-acpi.c
@@ -155,7 +155,7 @@ static int i2c_acpi_add_resource(struct acpi_resource *ares, void *data)
  */
 int i2c_acpi_get_irq(struct device *dev)
 {
-	struct acpi_device *adev = container_of(dev, struct acpi_device, dev);
+	struct acpi_device *adev = ACPI_COMPANION(dev);
 	struct list_head resource_list;
 	int irq = -ENOENT;
 	int ret;
@@ -207,11 +207,6 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
 	if (adapter_handle)
 		*adapter_handle = lookup.adapter_handle;
 
-	/* Then fill IRQ number if any */
-	info->irq = i2c_acpi_get_irq(&adev->dev);
-	if (info->irq < 0)
-		return info->irq;
-
 	acpi_set_modalias(adev, dev_name(&adev->dev), info->type,
 			  sizeof(info->type));
 
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 8a303246d534b..34de732598533 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -327,7 +327,10 @@ static int i2c_device_probe(struct device *dev)
 			if (irq == -EINVAL || irq == -ENODATA)
 				irq = of_irq_get(dev->of_node, 0);
 		} else if (ACPI_COMPANION(dev)) {
-			irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0);
+			irq = i2c_acpi_get_irq(dev);
+
+			if (irq == -ENOENT)
+				irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0);
 		}
 		if (irq == -EPROBE_DEFER)
 			return irq;
-- 
2.11.0

  parent reply	other threads:[~2019-06-21 10:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 10:08 [PATCH v6 0/7] I2C IRQ Probe Improvements Charles Keepax
2019-06-21 10:08 ` [PATCH v6 1/7] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
2019-06-21 10:08 ` [PATCH v6 2/7] i2c: acpi: Use available IRQ helper functions Charles Keepax
2019-06-21 10:08 ` [PATCH v6 3/7] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
2019-06-21 10:08 ` [PATCH v6 4/7] i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core Charles Keepax
2019-06-21 12:24   ` Andy Shevchenko
2019-06-25 11:50   ` Mika Westerberg
2019-06-25 12:42     ` Charles Keepax
2019-06-25 13:25       ` Andy Shevchenko
2019-06-26 12:58         ` Charles Keepax
2019-06-21 10:08 ` Charles Keepax [this message]
2019-06-21 10:08 ` [PATCH v6 6/7] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
2019-06-21 10:08 ` [PATCH v6 7/7] i2c: core: Tidy up handling of init_irq Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621100815.12417-6-ckeepax@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jbroadus@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=patches@opensource.cirrus.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).