From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com,
jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
benjamin.tissoires@redhat.com, jbroadus@gmail.com,
patches@opensource.cirrus.com
Subject: Re: [PATCH v6 4/7] i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core
Date: Fri, 21 Jun 2019 15:24:06 +0300 [thread overview]
Message-ID: <20190621122406.GL9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190621100815.12417-5-ckeepax@opensource.cirrus.com>
On Fri, Jun 21, 2019 at 11:08:12AM +0100, Charles Keepax wrote:
> In preparation for more refactoring make i2c_acpi_get_irq available
> outside i2c-core-acpi.c.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>
> Changes since v5:
> - Pass a struct device rather than acpi_device to i2c_acpi_get_irq,
> note this is more awkward than I would have liked as I am very
> unconvinced that adev->dev can actually be passed to
> ACPI_COMPANION. If anyone can answer that for sure that would be
> very helpful.
Sounds you are right. I stand corrected.
We can not use ACPI_COMPANION() against &adev->dev.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-06-21 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 10:08 [PATCH v6 0/7] I2C IRQ Probe Improvements Charles Keepax
2019-06-21 10:08 ` [PATCH v6 1/7] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
2019-06-21 10:08 ` [PATCH v6 2/7] i2c: acpi: Use available IRQ helper functions Charles Keepax
2019-06-21 10:08 ` [PATCH v6 3/7] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
2019-06-21 10:08 ` [PATCH v6 4/7] i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core Charles Keepax
2019-06-21 12:24 ` Andy Shevchenko [this message]
2019-06-25 11:50 ` Mika Westerberg
2019-06-25 12:42 ` Charles Keepax
2019-06-25 13:25 ` Andy Shevchenko
2019-06-26 12:58 ` Charles Keepax
2019-06-21 10:08 ` [PATCH v6 5/7] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
2019-06-21 10:08 ` [PATCH v6 6/7] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
2019-06-21 10:08 ` [PATCH v6 7/7] i2c: core: Tidy up handling of init_irq Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621122406.GL9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jbroadus@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).