From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com,
jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
benjamin.tissoires@redhat.com, jbroadus@gmail.com,
patches@opensource.cirrus.com
Subject: Re: [PATCH v7 2/6] i2c: acpi: Use available IRQ helper functions
Date: Wed, 26 Jun 2019 22:09:06 +0300 [thread overview]
Message-ID: <20190626190906.GA9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190626150302.22703-3-ckeepax@opensource.cirrus.com>
On Wed, Jun 26, 2019 at 04:02:58PM +0100, Charles Keepax wrote:
> Use the available IRQ helper functions, most of the functions have
> additional helpful side affects like configuring the trigger type of the
> IRQ.
> - acpi_dev_free_resource_list(&resource_list);
I have thought that we can drop completely the resource_list, though ACPI
doesn't allow this. So, I would rather withdraw this change to be on the safe
(symmetrical) side.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-06-26 19:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 15:02 [PATCH v7 0/6] I2C IRQ Probe Improvements Charles Keepax
2019-06-26 15:02 ` [PATCH v7 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
2019-06-26 15:02 ` [PATCH v7 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax
2019-06-26 19:09 ` Andy Shevchenko [this message]
2019-06-27 8:18 ` Charles Keepax
2019-06-26 15:02 ` [PATCH v7 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
2019-06-26 15:03 ` [PATCH v7 4/6] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
2019-06-26 15:03 ` [PATCH v7 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
2019-06-26 15:03 ` [PATCH v7 6/6] i2c: core: Tidy up handling of init_irq Charles Keepax
2019-06-26 19:11 ` [PATCH v7 0/6] I2C IRQ Probe Improvements Andy Shevchenko
2019-06-29 11:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626190906.GA9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jbroadus@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).