From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v7 2/6] i2c: acpi: Use available IRQ helper functions Date: Wed, 26 Jun 2019 22:09:06 +0300 Message-ID: <20190626190906.GA9224@smile.fi.intel.com> References: <20190626150302.22703-1-ckeepax@opensource.cirrus.com> <20190626150302.22703-3-ckeepax@opensource.cirrus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190626150302.22703-3-ckeepax@opensource.cirrus.com> Sender: linux-kernel-owner@vger.kernel.org To: Charles Keepax Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com List-Id: linux-i2c@vger.kernel.org On Wed, Jun 26, 2019 at 04:02:58PM +0100, Charles Keepax wrote: > Use the available IRQ helper functions, most of the functions have > additional helpful side affects like configuring the trigger type of the > IRQ. > - acpi_dev_free_resource_list(&resource_list); I have thought that we can drop completely the resource_list, though ACPI doesn't allow this. So, I would rather withdraw this change to be on the safe (symmetrical) side. -- With Best Regards, Andy Shevchenko