From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v7 0/6] I2C IRQ Probe Improvements Date: Wed, 26 Jun 2019 22:11:10 +0300 Message-ID: <20190626191110.GB9224@smile.fi.intel.com> References: <20190626150302.22703-1-ckeepax@opensource.cirrus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190626150302.22703-1-ckeepax@opensource.cirrus.com> Sender: linux-kernel-owner@vger.kernel.org To: Charles Keepax Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com List-Id: linux-i2c@vger.kernel.org On Wed, Jun 26, 2019 at 04:02:56PM +0100, Charles Keepax wrote: > This series attempts to align as much IRQ handling into the > probe path as possible. Note that I don't have a great setup > for testing these patches so they are mostly just build tested > and need careful review and testing before any of them are > merged. > > The series brings the ACPI path inline with the way the device > tree path handles the IRQ entirely at probe time. However, > it still leaves any IRQ specified through the board_info as > being handled at device time. In that case we need to cache > something from the board_info until probe time, which leaves > any alternative solution with something basically the same as > the current handling although perhaps caching more stuff. > Thanks! After addressing one comment, take my Reviewed-by: Andy Shevchenko for all patches which lack it now. > Thanks, > Charles > > See previous discussions: > - https://lkml.org/lkml/2019/2/15/989 > - https://www.spinics.net/lists/linux-i2c/msg39541.html > > Charles Keepax (6): > i2c: core: Allow whole core to use i2c_dev_irq_from_resources > i2c: acpi: Use available IRQ helper functions > i2c: acpi: Factor out getting the IRQ from ACPI > i2c: core: Move ACPI IRQ handling to probe time > i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq > i2c: core: Tidy up handling of init_irq > > drivers/i2c/i2c-core-acpi.c | 59 ++++++++++++++++++++++++++++++++------------- > drivers/i2c/i2c-core-base.c | 11 +++++---- > drivers/i2c/i2c-core.h | 9 +++++++ > 3 files changed, 57 insertions(+), 22 deletions(-) > > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko