From: Wolfram Sang <wsa@the-dreams.de>
To: Edward Cree <ecree@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
wsa+renesas@sang-engineering.com, linux-i2c@vger.kernel.org,
linux-net-drivers@solarflare.com, mhabets@solarflare.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device
Date: Thu, 25 Jul 2019 21:27:04 +0200 [thread overview]
Message-ID: <20190725192704.GB1440@kunai> (raw)
In-Reply-To: <72968faa-e260-3640-99be-9c63bc79ad5e@solarflare.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
> >> Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an
> >> ERRPTR which we use in error handling.
> >>
> >> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Subject & description are incomplete, you're also changing i2c_new_device()
> to i2c_new_client_device().
Right, this was an anomaly with this patch to have both code paths
returning an ERRPTR. The big conversion for i2c_new_device will come
later in a seperate series.
> Other than that,
> Acked-by: Edward Cree <ecree@solarflare.com>
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-07-25 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 17:26 [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device Wolfram Sang
2019-07-24 22:47 ` David Miller
2019-07-25 12:37 ` Edward Cree
2019-07-25 19:27 ` Wolfram Sang [this message]
2019-07-25 18:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725192704.GB1440@kunai \
--to=wsa@the-dreams.de \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).