* [PATCH] i2c: s3c2410: Mark expected switch fall-through
@ 2019-07-28 23:51 Gustavo A. R. Silva
2019-07-29 16:34 ` Kees Cook
2019-08-01 13:01 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-28 23:51 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-samsung-soc, linux-i2c, linux-kernel,
Gustavo A. R. Silva, Stephen Rothwell, Kees Cook
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/i2c/busses/i2c-s3c2410.c: In function 'i2c_s3c_irq_nextbyte':
drivers/i2c/busses/i2c-s3c2410.c:431:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (i2c->state == STATE_READ)
^
drivers/i2c/busses/i2c-s3c2410.c:439:2: note: here
case STATE_WRITE:
^~~~
Notice that, in this particular case, the code comment is
modified in accordance with what GCC is expecting to find.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index d97fb857b0ea..c98ef4c4a0c9 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -435,6 +435,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
* fall through to the write state, as we will need to
* send a byte as well
*/
+ /* Fall through */
case STATE_WRITE:
/*
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: s3c2410: Mark expected switch fall-through
2019-07-28 23:51 [PATCH] i2c: s3c2410: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-07-29 16:34 ` Kees Cook
2019-08-01 13:01 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2019-07-29 16:34 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-arm-kernel,
linux-samsung-soc, linux-i2c, linux-kernel, Stephen Rothwell
On Sun, Jul 28, 2019 at 06:51:38PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/i2c/busses/i2c-s3c2410.c: In function 'i2c_s3c_irq_nextbyte':
> drivers/i2c/busses/i2c-s3c2410.c:431:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (i2c->state == STATE_READ)
> ^
> drivers/i2c/busses/i2c-s3c2410.c:439:2: note: here
> case STATE_WRITE:
> ^~~~
>
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index d97fb857b0ea..c98ef4c4a0c9 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -435,6 +435,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
> * fall through to the write state, as we will need to
> * send a byte as well
> */
> + /* Fall through */
>
> case STATE_WRITE:
> /*
> --
> 2.22.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: s3c2410: Mark expected switch fall-through
2019-07-28 23:51 [PATCH] i2c: s3c2410: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 16:34 ` Kees Cook
@ 2019-08-01 13:01 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2019-08-01 13:01 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-arm-kernel,
linux-samsung-soc, linux-i2c, linux-kernel, Stephen Rothwell,
Kees Cook
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Sun, Jul 28, 2019 at 06:51:38PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/i2c/busses/i2c-s3c2410.c: In function 'i2c_s3c_irq_nextbyte':
> drivers/i2c/busses/i2c-s3c2410.c:431:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (i2c->state == STATE_READ)
> ^
> drivers/i2c/busses/i2c-s3c2410.c:439:2: note: here
> case STATE_WRITE:
> ^~~~
>
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-01 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-28 23:51 [PATCH] i2c: s3c2410: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 16:34 ` Kees Cook
2019-08-01 13:01 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).