From: Wolfram Sang <wsa@the-dreams.de>
To: "Adamski, Krzysztof (Nokia - PL/Wroclaw)" <krzysztof.adamski@nokia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"Sverdlin,
Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com>
Subject: Re: [PATCH v2] i2c: axxia: support slave mode
Date: Wed, 14 Aug 2019 15:13:35 +0200 [thread overview]
Message-ID: <20190814131335.GF9716@ninjato> (raw)
In-Reply-To: <20190809091709.GA24838@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Hi Krzysztof,
> - Reduced the number of dev_dbg messages.
Yes, that looks good. Just some curly braces left over...
> + if (fifo_status & SLV_FIFO_STRC) {
> + i2c_slave_event(idev->slave,
> + I2C_SLAVE_WRITE_REQUESTED, &val);
> + }
...
> + if (fifo_status & SLV_FIFO_RSC) {
> + readl(idev->base + SLV_DATA); /* dummy read */
> + }
..
> + if (status & SLV_STATUS_SRC1) {
> + i2c_slave_event(idev->slave, I2C_SLAVE_STOP, &val);
> + }
If you add '--strict' to checkpatch, it warns about two of them.
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-14 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 9:17 [PATCH v2] i2c: axxia: support slave mode Adamski, Krzysztof (Nokia - PL/Wroclaw)
2019-08-14 13:13 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814131335.GF9716@ninjato \
--to=wsa@the-dreams.de \
--cc=alexander.sverdlin@nokia.com \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).