Re: [PATCH RESEND] i2c: mediatek: disable zero-length transfers for mt8183

Yingjoe Chen
2019-08-22T08:24:38Z

On Thu, 2019-08-22 at 13:57 +0800, Hsin-Yi Wang wrote:
> When doing i2cdetect quick write mode, we would get transfer
> error ENOMEM, and i2cdetect shows there's no device at the address.
> Quoting from mt8183 datasheet, the number of transfers to be
> transferred in one transaction should be set to bigger than 1,
> so we should forbid zero-length transfer and update functionality.

<...>

> @@ -933,8 +942,8 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> i2c->dev = &pdev->dev;
> i2c->adap.dev.parent = &pdev->dev;
> i2c->adap.owner = THIS_MODULE;
> - i2c->adap.algo = &mtk_i2c_algorithm;
> i2c->adap.quirks = i2c->dev_comp->quirks;
> + i2c->adap.algo = &mtk_i2c_algorithm;
> i2c->adap.timeout = 2 * HZ;
> i2c->adap.retries = 1;
>

Why do you need to change this part?

Joe.C