From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v5 3/3] i2c: piix4: Add ACPI support Date: Thu, 29 Aug 2019 22:21:02 +0200 Message-ID: <20190829202102.GS3740@ninjato> References: <20190802145109.38dd4045@endymion> <20190802145526.6edba0a6@endymion> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UFRfxei4j9xfgtfb" Return-path: Content-Disposition: inline In-Reply-To: <20190802145526.6edba0a6@endymion> Sender: linux-kernel-owner@vger.kernel.org To: Jean Delvare Cc: Linux I2C , linux-kernel@vger.kernel.org, Andrew Cooks , linux-acpi@vger.kernel.org, platypus-sw@opengear.com, "Tobin C . Harding" , Guenter Roeck , Will Wagner List-Id: linux-i2c@vger.kernel.org --UFRfxei4j9xfgtfb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 02, 2019 at 02:55:26PM +0200, Jean Delvare wrote: > Enable the i2c-piix4 SMBus controller driver to enumerate I2C slave > devices using ACPI. It builds on the related I2C mux device work > in commit 8eb5c87a92c0 ("i2c: add ACPI support for I2C mux ports") >=20 > In the i2c-piix4 driver the adapters are enumerated as: > Main SMBus adapter Port 0, Port 2, ..., aux port (i.e., ASF adapter) >=20 > However, in the AMD BKDG documentation[1], the implied order of ports is: > Main SMBus adapter Port 0, ASF adapter, Port 2, Port 3, ... >=20 > This ordering difference is unfortunate. We assume that ACPI > developers will use the AMD documentation ordering, so we have to > pass an extra parameter to piix4_add_adapter(). >=20 > [1] 52740 BIOS and Kernel Developer's Guide (BKDG) for AMD Family 16h > Models 30h-3Fh Processors >=20 > Based on earlier work by Andrew Cooks. >=20 > Reported-by: Andrew Cooks > Signed-off-by: Jean Delvare Applied to for-next, thanks! --UFRfxei4j9xfgtfb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl1oM64ACgkQFA3kzBSg KbaMRg/+OOl8TdOzxtR2FewvdqEPOl2p/SvaK9SEFqYndD4QYq2+gIOG3ROK4ovQ P19jHsbob6OQm8BrSEO3wFNq1kqQRRNKev7235NGeK5pYbj5trTdKIUmGbysxFwO oHwEdxsuX76ofm26XU/mlAuxfUWLPbK9u9ASJdUNMU+gcG0UHlAWwvaanBeGoUGR icOaIe5DC475rZh6tDyGvYJGFx0De9NQm/TtNAdGzvZTamK/K04q0viqoaBtRcjA fvG7uBT/eaTa2bHwK7RzvcKCXUL8HfgyHJ0eQemaa5KeKsJ4AlXjgFdl55cipQlM gai3FXMFrp9Dme5XhxWFDibjvq57I4Mb45xYfOq9r0xtIKuSlHicRQVnvM7njc8E aTy5aRrPw7a5K5sSxz6DBMf8MThWuX5TLEwsYJPLjYCgC/0Ek7Kg9USqU8oAWZPr 0LiNvJ/Z46RXyqkrSBrmEzwKtdZ5/CX+T6HailqLhNbACgUuMafKCTAW6FZYqIaU cSiXwqlvjEk2pSoy9l9FThZVSBGE194hhol4HH4Dajzz9NWMiP4IPOylm0o1Ssgh 8d5HHCNT5+8keWqaiWLGhUkO+0Oe+DMwtdsyJTLIMlQ8jTqUHt5h3+cOK2x0E1mN 3G4szoUEaR6DnQ2T2juQicbquyiqAK4AxXjCqT6tOigP2nBgjR4= =mybI -----END PGP SIGNATURE----- --UFRfxei4j9xfgtfb--