From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device() Date: Fri, 30 Aug 2019 14:53:38 +0200 Message-ID: <20190830125338.GP21922@piout.net> References: <20190820154239.8230-1-wsa+renesas@sang-engineering.com> <20190820154239.8230-2-wsa+renesas@sang-engineering.com> <20190829205752.GL21922@piout.net> <20190830124554.GB2870@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190830124554.GB2870@ninjato> Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Alessandro Zummo , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 30/08/2019 14:45:54+0200, Wolfram Sang wrote: > On Thu, Aug 29, 2019 at 10:57:52PM +0200, Alexandre Belloni wrote: > > On 20/08/2019 17:42:37+0200, Wolfram Sang wrote: > > > I was about to simplify the call to i2c_unregister_device() when I > > > realized that converting to devm_i2c_new_dummy_device() will simplify > > > the driver a lot. So I took this approach. > > > > > > Signed-off-by: Wolfram Sang > > > --- > > > Build tested only, buildbot is happy, too. > > > > > > Please apply to your tree. > > > > > > > I'm confused because I already applied: > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=7150710f3084de8d35ce3221eeae2caee8813f92 > > The above was a mass conversion to i2c_new_dummy_device() to make sure > all in-kernel users use the API returning an ERRPTR. Mass conversion to > the devm_ variant of the same function was too troublesome. > > With another series, I wanted to remove superfluous error checking of > i2c_unregister_device() because it is NULL-ptr safe, like here: > > > > - if (info->rtc) > > > - i2c_unregister_device(info->rtc); > > But for these two RTC drivers, I figured moving to devm_* is way easier > than fixing up the mass conversion result from coccinelle. > Ok so should I drop the previous patches and apply those instead? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com