From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] i2c: aspeed: fix master pending state handling Date: Mon, 21 Oct 2019 14:09:45 +0200 Message-ID: <20191021120945.GC1145@ninjato> References: <20191009212034.20325-1-jae.hyun.yoo@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3300174731796616513==" Return-path: In-Reply-To: <20191009212034.20325-1-jae.hyun.yoo@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jae Hyun Yoo Cc: Mark Rutland , devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Benjamin Herrenschmidt , openbmc@lists.ozlabs.org, Brendan Higgins , linux-i2c@vger.kernel.org, Rob Herring , Joel Stanley , Tao Ren , linux-arm-kernel@lists.infradead.org, Cedric Le Goater List-Id: linux-i2c@vger.kernel.org --===============3300174731796616513== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4ZLFUWh1odzi/v6L" Content-Disposition: inline --4ZLFUWh1odzi/v6L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 09, 2019 at 02:20:34PM -0700, Jae Hyun Yoo wrote: > In case of master pending state, it should not trigger a master > command, otherwise data could be corrupted because this H/W shares > the same data buffer for slave and master operations. It also means > that H/W command queue handling is unreliable because of the buffer > sharing issue. To fix this issue, it clears command queue if a > master command is queued in pending state to use S/W solution > instead of H/W command queue handling. Also, it refines restarting > mechanism of the pending master command. >=20 > Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support") > Signed-off-by: Jae Hyun Yoo Applied to for-current, thanks! --4ZLFUWh1odzi/v6L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl2toAUACgkQFA3kzBSg Kba5gw//TeZ9Sn0wM9c2yDDqlKcM/U6TRZYv/mqcZCi5l8hjGfnb/HmnpQN8R/7M 3BrEsK1Zu3FqYbL1JOliu/i91YHd7tAo1lju2claxrX5NbnS2rcEQo4NAxnFG5yK Ni3sdX1ymQUIxbsjrM/2bhJNOtUFi/j/4ILyFKAyU/bNUZcmbXJHgBIQyFOAHrRX jpRdPxw7CVro9haEtJV5b6Dk+YAl7aSva82Nu/GFelURpRJDb3Y3/AcKxPTrJ1/u dydZoenb5S1uY15faP8/0H+cL7LfB5PmxwbnKRO+dI1HDlUVHA6GHFhFQhaAsD5b kJ4kfmXzI4TR/YjcBArtMsdnXSnwq361pc5VkSiJ8EGLZ2tiuY3sPUxyUSoqEGtT thAp0K+im/VGdqZVUm8q8n0JTW5CwWGocVVbR/XDkoWgM7Jm9oLOK/VTVsO7N3ih xHgKnuQ4KMDE2+2rzn5wVTEqyeHUswAcAMNMDXZ4IE1JYI1dj+MDw2s+zYkgoTPJ 9r0zJP0CHj8epiRg09qsQ6xl2iyiAUMIH2uyf+a51fTdBN2BeCNTtWd6VciWuPwM pAi25JK/ejgOLdCxfGnfnh8u1C5Zp0p40wqtPywwGeynoxdGFMfrfmnPBfP6Qjbl UUPS4tdFuKJgRv17zVNlfe8bayTm6Lk5/jrgYEuyLp7nqt2/714= =yVes -----END PGP SIGNATURE----- --4ZLFUWh1odzi/v6L-- --===============3300174731796616513== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3300174731796616513==--