* [PATCH] i2c: hix5hd2: add missed clk_disable_unprepare in remove
@ 2019-11-04 15:00 Chuhong Yuan
2020-03-22 16:14 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-04 15:00 UTC (permalink / raw)
Cc: linux-i2c, linux-kernel, Chuhong Yuan
The driver forgets to disable and unprepare clk when remove.
Add a call to clk_disable_unprepare to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/i2c/busses/i2c-hix5hd2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
index 8497c7a95dd4..224f830f77f9 100644
--- a/drivers/i2c/busses/i2c-hix5hd2.c
+++ b/drivers/i2c/busses/i2c-hix5hd2.c
@@ -477,6 +477,7 @@ static int hix5hd2_i2c_remove(struct platform_device *pdev)
i2c_del_adapter(&priv->adap);
pm_runtime_disable(priv->dev);
pm_runtime_set_suspended(priv->dev);
+ clk_disable_unprepare(priv->clk);
return 0;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: hix5hd2: add missed clk_disable_unprepare in remove
2019-11-04 15:00 [PATCH] i2c: hix5hd2: add missed clk_disable_unprepare in remove Chuhong Yuan
@ 2020-03-22 16:14 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2020-03-22 16:14 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
On Mon, Nov 04, 2019 at 11:00:48PM +0800, Chuhong Yuan wrote:
> The driver forgets to disable and unprepare clk when remove.
> Add a call to clk_disable_unprepare to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-22 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-04 15:00 [PATCH] i2c: hix5hd2: add missed clk_disable_unprepare in remove Chuhong Yuan
2020-03-22 16:14 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).