From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] treewide: remove redundent IS_ERR() before error code check Date: Sun, 05 Jan 2020 22:02:45 -0800 Message-ID: <20200106060246.49A5720848@mail.kernel.org> References: <20200106045833.1725-1-masahiroy@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Morton Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Masahiro Yamada , linux-kernel@vger.kernel.org, Julia Lawall , linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org Quoting Masahiro Yamada (2020-01-05 20:58:33) > 'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. > > The semantic patch that generates this commit is as follows: > > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code) > +PTR_ERR(ptr) == - error_code > // > > Signed-off-by: Masahiro Yamada > --- For > drivers/clk/clk.c | 2 +- Acked-by: Stephen Boyd