From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 06/12] i2c: taos-evm: convert to use i2c_new_client_device() Date: Wed, 15 Jan 2020 20:56:21 +0100 Message-ID: <20200115195621.GB23789@ninjato> References: <20200107174748.9616-1-wsa+renesas@sang-engineering.com> <20200107174748.9616-7-wsa+renesas@sang-engineering.com> <20200108115822.20871d77@endymion> <20200109094228.2e058653@endymion> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QTprm0S8XgL7H0Dt" Return-path: Content-Disposition: inline In-Reply-To: <20200109094228.2e058653@endymion> Sender: linux-kernel-owner@vger.kernel.org To: Jean Delvare Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-i2c@vger.kernel.org --QTprm0S8XgL7H0Dt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > In my opinion -ENODEV should only be used for "I expected a device but > could not find it". For the case where we simply don't know what slave > device to instantiate, NULL seems more appropriate, as it's not an > error. Well, I copied the behaviour from driver core here. -ENODEV is the one errno where no messages will be displayed when returned from probe. So, I think we can keep it as is. --QTprm0S8XgL7H0Dt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl4fbmUACgkQFA3kzBSg KbZROxAAqc2hmKmkG203rrtIiUXGmbpTvszqf/43X9B9O1wXnGdxx1x6WSWTX4YB XxEdu03zUqg0uop2ISE3lb9QhS9de4X0WRGwg+U1y2jAwgDXs/ZPNC1tpkUsXl97 2k61rSY2Xzgit70Lul4Y5JpZ/xEtpx9FFMrREMCkzUz7D9xol5gtnX+nkiOVJnPn Pq7FN/Euvo3zpFHoDW5DFDsSM110d1KbSM1+gE8BxUrOpJVX1UHur8NQKcvMCMBL vc7bG+UsLZi3OJb58wpkgnSrFJaWhulcckjWTkPMnWeFy+0QZA5EJindpaSNE1sw 2X950JNs0I8SUO4BtyEJCCsHMnkibaU7Pa57WN6DtYM+DX7DX9I7goQSGHZ5mN9M 0zz6eMQZyk6qTab+lhk2n9yuIyBhjqE4OZoxKJ/kKDj0R8lxT35NLBpNxu52/g6v kfbJY1SkhwCeBo2aBmHZG0Hcj45Ef51RPZcYdyYSyEFzVBIpTUF8JbpvA1UcH08f 1BaIhlFQKNp3eadlq+/hsnyiKs1wsogvOFirDBm6D0JU0k4CSLuWGXtBIexbYiIO Dx6G9VmKa3w/7uNzXVOWSX5ukiWEUeH25/WnPkfrYZBy+bsbtPn5zyyv+6Z90eK9 mgNOgEbLxkrBrUligXqMGD5tdyufSH02hO7OkgxNGag9w726V7k= =kYJM -----END PGP SIGNATURE----- --QTprm0S8XgL7H0Dt--