From: Jean Delvare <jdelvare@suse.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Luca Ceresoli <luca@lucaceresoli.net>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.5 495/542] docs: i2c: writing-clients: properly name the stop condition
Date: Sat, 15 Feb 2020 07:14:02 +0100 [thread overview]
Message-ID: <20200215071402.027c9120@endymion> (raw)
In-Reply-To: <20200214154854.6746-495-sashal@kernel.org>
On Fri, 14 Feb 2020 10:48:07 -0500, Sasha Levin wrote:
> From: Luca Ceresoli <luca@lucaceresoli.net>
>
> [ Upstream commit 4fcb445ec688a62da9c864ab05a4bd39b0307cdc ]
>
> In I2C there is no such thing as a "stop bit". Use the proper naming: "stop
> condition".
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> Documentation/i2c/writing-clients.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/i2c/writing-clients.rst b/Documentation/i2c/writing-clients.rst
> index ced309b5e0cc8..3869efdf84cae 100644
> --- a/Documentation/i2c/writing-clients.rst
> +++ b/Documentation/i2c/writing-clients.rst
> @@ -357,9 +357,9 @@ read/written.
>
> This sends a series of messages. Each message can be a read or write,
> and they can be mixed in any way. The transactions are combined: no
> -stop bit is sent between transaction. The i2c_msg structure contains
> -for each message the client address, the number of bytes of the message
> -and the message data itself.
> +stop condition is issued between transaction. The i2c_msg structure
> +contains for each message the client address, the number of bytes of the
> +message and the message data itself.
>
> You can read the file ``i2c-protocol`` for more information about the
> actual I2C protocol.
I wouldn't bother backporting this documentation patch to stable and
longterm trees. That's a minor vocabulary thing really, it does not
qualify.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-02-15 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200214154854.6746-1-sashal@kernel.org>
2020-02-14 15:48 ` [PATCH AUTOSEL 5.5 495/542] docs: i2c: writing-clients: properly name the stop condition Sasha Levin
2020-02-15 6:14 ` Jean Delvare [this message]
2020-02-16 21:49 ` Luca Ceresoli
2020-02-17 0:06 ` Sasha Levin
2020-02-14 15:48 ` [PATCH AUTOSEL 5.5 500/542] i2c: cros-ec-tunnel: Fix slave device enumeration Sasha Levin
2020-02-14 15:48 ` [PATCH AUTOSEL 5.5 501/542] i2c: cros-ec-tunnel: Fix ACPI identifier Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215071402.027c9120@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox