From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Rosin <peda@axentia.se>,
Javier Martinez Canillas <javierm@redhat.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v1 2/5] i2c: mux: pca954x: Make use of device properties
Date: Fri, 6 Mar 2020 11:54:13 +0200 [thread overview]
Message-ID: <20200306095413.GQ1224808@smile.fi.intel.com> (raw)
In-Reply-To: <cf0cf14f-4e43-2a9c-63ed-f5f03ea7b114@axentia.se>
On Thu, Mar 05, 2020 at 09:05:56PM +0000, Peter Rosin wrote:
> On 2020-03-05 16:53, Andy Shevchenko wrote:
> > Device property API allows to gather device resources from different sources,
> > such as ACPI. Convert the drivers to unleash the power of device property API.
...
> > static const struct i2c_device_id pca954x_id[] = {
> > - { "pca9540", pca_9540 },
> > - { "pca9542", pca_9542 },
> > - { "pca9543", pca_9543 },
> > - { "pca9544", pca_9544 },
> > - { "pca9545", pca_9545 },
> > - { "pca9546", pca_9546 },
> > - { "pca9547", pca_9547 },
> > - { "pca9548", pca_9548 },
> > - { "pca9846", pca_9846 },
> > - { "pca9847", pca_9847 },
> > - { "pca9848", pca_9848 },
> > - { "pca9849", pca_9849 },
> > + { "pca9540", .driver_data = (kernel_ulong_t)&chips[pca_9540] },
> > + { "pca9542", .driver_data = (kernel_ulong_t)&chips[pca_9542] },
> > + { "pca9543", .driver_data = (kernel_ulong_t)&chips[pca_9543] },
> > + { "pca9544", .driver_data = (kernel_ulong_t)&chips[pca_9544] },
> > + { "pca9545", .driver_data = (kernel_ulong_t)&chips[pca_9545] },
> > + { "pca9546", .driver_data = (kernel_ulong_t)&chips[pca_9546] },
> > + { "pca9547", .driver_data = (kernel_ulong_t)&chips[pca_9547] },
> > + { "pca9548", .driver_data = (kernel_ulong_t)&chips[pca_9548] },
> > + { "pca9846", .driver_data = (kernel_ulong_t)&chips[pca_9846] },
> > + { "pca9847", .driver_data = (kernel_ulong_t)&chips[pca_9847] },
> > + { "pca9848", .driver_data = (kernel_ulong_t)&chips[pca_9848] },
> > + { "pca9849", .driver_data = (kernel_ulong_t)&chips[pca_9849] },
>
> It feels odd/wrong to specifically name .driver_data when .name is not there.
> None or both...
I will add .name as well.
> > + data->chip = device_get_match_data(dev);
> > if (!data->chip)
> > data->chip = &chips[id->driver_data];
>
> These two lines no longer make any sence.
Please elaborate.
IIRC Javier explained once that I²C ID table is still good to have to allow
enumeration from user space.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-06 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 15:53 [PATCH v1 1/5] i2c: mux: pca954x: Refactor pca954x_irq_handler() Andy Shevchenko
2020-03-05 15:53 ` [PATCH v1 2/5] i2c: mux: pca954x: Make use of device properties Andy Shevchenko
2020-03-05 21:05 ` Peter Rosin
2020-03-06 9:54 ` Andy Shevchenko [this message]
2020-03-06 11:48 ` Peter Rosin
2020-03-06 13:58 ` Andy Shevchenko
2020-03-06 14:57 ` Peter Rosin
2020-03-06 15:07 ` Andy Shevchenko
2020-03-05 15:53 ` [PATCH v1 3/5] i2c: mux: pca954x: Drop useless validation for optional GPIO descriptor Andy Shevchenko
2020-03-05 21:19 ` Peter Rosin
2020-03-06 9:56 ` Andy Shevchenko
2020-03-05 15:53 ` [PATCH v1 4/5] i2c: mux: pca954x: Move device_remove_file() out of pca954x_cleanup() Andy Shevchenko
2020-03-05 15:53 ` [PATCH v1 5/5] i2c: mux: pca954x: Convert license to SPDX identifier Andy Shevchenko
2020-03-05 21:34 ` [PATCH v1 1/5] i2c: mux: pca954x: Refactor pca954x_irq_handler() Peter Rosin
2020-03-06 10:02 ` Andy Shevchenko
2020-03-06 10:58 ` Peter Rosin
2020-03-16 16:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306095413.GQ1224808@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox