From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Rosin <peda@axentia.se>
Cc: Wolfram Sang <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v2 1/3] i2c: core: Provide generic definitions for bus frequencies
Date: Mon, 16 Mar 2020 17:51:17 +0200 [thread overview]
Message-ID: <20200316155117.GR1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200306101049.GT1224808@smile.fi.intel.com>
On Fri, Mar 06, 2020 at 12:10:49PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 05, 2020 at 09:58:29PM +0000, Peter Rosin wrote:
> > On 2020-02-27 13:21, Andy Shevchenko wrote:
...
> > > +/* I2C Frequency Modes */
> > > +#define I2C_MAX_STANDARD_MODE_FREQ 100000
> > > +#define I2C_MAX_FAST_MODE_FREQ 400000
> > > +#define I2C_MAX_FAST_PLUS_MODE_FREQ 1000000
> > > +#define I2C_MAX_TURBO_MODE_FREQ 1400000
> > > +#define I2C_MAX_HIGH_SPEED_MODE_FREQ 3400000
> > > +#define I2C_MAX_ULTRA_SPEED_MODE_FREQ 5000000
> > I can't seem to
> > remember what frequency TURBO, HIGH, etc are and their ordering is
> > difficult. It's all sounds like marketing buzz to me and my brain shuts
> > off instantly.
> >
> > This feels a lot like moving away from octal permissions for files, which
> > is frowned upon...
> >
> > Can we include some kind of indication of the actual frequency in the
> > names as well please?
> >
> > Perhaps something like I2C_MAX_STANDARD_MODE_100KHZ?
>
> It's definitely a duplicate information here.
>
> In I²C we have quite established range of frequencies (4 out of 6 in above
> list), so, their names already implying very well defined frequencies.
Actually 5 out of 6. In new version (just sent) I put a link to Wiki.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-03-16 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 12:21 [PATCH v2 1/3] i2c: core: Provide generic definitions for bus frequencies Andy Shevchenko
2020-02-27 12:21 ` [PATCH v2 2/3] i2c: algo: Use " Andy Shevchenko
[not found] ` <20200227122129.65516-3-andriy.shevchenko@linux.intel.com>
2020-02-27 12:42 ` [PATCH v2 3/3] i2c: drivers: " yamada.masahiro
2020-03-05 16:29 ` Pierre Yves MORDRET
2020-03-06 8:12 ` Pierre Yves MORDRET
2020-03-02 8:43 ` Pierre Yves MORDRET
2020-03-02 10:09 ` Patrice CHOTARD
2020-03-05 16:12 ` Pierre Yves MORDRET
2020-03-05 16:21 ` Pierre Yves MORDRET
2020-03-05 23:37 ` Thor Thayer
2020-03-05 21:58 ` [PATCH v2 1/3] i2c: core: Provide " Peter Rosin
2020-03-06 10:10 ` Andy Shevchenko
2020-03-16 15:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316155117.GR1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).