From: Patrick Williams <patrick@stwcx.xyz>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "Patrick Williams" <alpawi@amazon.com>,
"Björn Ardö" <bjorn.ardo@axis.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: slave-eeprom: support additional models
Date: Mon, 20 Apr 2020 15:23:10 -0500 [thread overview]
Message-ID: <20200420202310.GA95151@heinlein.lan.stwcx.xyz> (raw)
In-Reply-To: <20200420164619.GE3721@ninjato>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On Mon, Apr 20, 2020 at 06:46:19PM +0200, Wolfram Sang wrote:
> On Tue, Oct 01, 2019 at 11:40:06AM -0500, Patrick Williams wrote:
> > Add support for emulating the following EEPROMs:
> > * 24c01 - 1024 bit
> > * 24c128 - 128k bit
> > * 24c256 - 256k bit
> > * 24c512 - 512k bit
> >
> > The flag bits in the device id were shifted up 1 bit to make
> > room for saving the 24c512's size. 24c512 uses the full 16-bit
> > address space of a 2-byte addressable EEPROM.
> >
> > Signed-off-by: Patrick Williams <alpawi@amazon.com>
>
> Do you really need them or is it just nice to have?
>
> I am undecided. I definately don't want all the EEPROM types which
> exist, but the full 16 bit address range makes sense...
>
> More opinions welcome.
>
I don't remember exactly which ones we needed (and I am no longer at
Amazon), but it was pretty trivial to add them all to the table so I
went ahead and did it. As long as we had one of the 2-byte addressable
EEPROMs, anything else necessary could be handleded as a small
out-of-tree patch.
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-20 20:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 16:40 [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly Patrick Williams
2019-10-01 16:40 ` [PATCH 2/2] i2c: slave-eeprom: support additional models Patrick Williams
2020-04-20 16:46 ` Wolfram Sang
2020-04-20 20:23 ` Patrick Williams [this message]
2019-10-02 6:20 ` [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly Bjorn Ardo
2020-04-20 16:43 ` Wolfram Sang
2020-04-20 20:24 ` Patrick Williams
2020-04-20 20:31 ` Patrick Williams
2020-04-20 20:53 ` Wolfram Sang
2020-04-21 12:03 ` Bjorn Ardo
2020-04-21 12:16 ` Wolfram Sang
2020-04-22 9:30 ` Bjorn Ardo
2020-04-22 9:36 ` Wolfram Sang
2020-04-24 9:06 ` Bjorn Ardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420202310.GA95151@heinlein.lan.stwcx.xyz \
--to=patrick@stwcx.xyz \
--cc=alpawi@amazon.com \
--cc=bjorn.ardo@axis.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).