From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FFFC54FC9 for ; Tue, 21 Apr 2020 12:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2392206A5 for ; Tue, 21 Apr 2020 12:17:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbgDUMRC (ORCPT ); Tue, 21 Apr 2020 08:17:02 -0400 Received: from sauhun.de ([88.99.104.3]:60144 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgDUMRC (ORCPT ); Tue, 21 Apr 2020 08:17:02 -0400 Received: from localhost (p54B336C5.dip0.t-ipconnect.de [84.179.54.197]) by pokefinder.org (Postfix) with ESMTPSA id AE2412C1FBE; Tue, 21 Apr 2020 14:16:59 +0200 (CEST) Date: Tue, 21 Apr 2020 14:16:59 +0200 From: Wolfram Sang To: Bjorn Ardo Cc: Patrick Williams , =?utf-8?B?QmrDtnJuIEFyZMO2?= , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly Message-ID: <20200421121659.GE1241@ninjato> References: <20191001164009.21610-1-alpawi@amazon.com> <150599be-9125-4ab9-e2a6-e792b41910e6@axis.com> <20200420164349.GD3721@ninjato> <20200420203146.GC95151@heinlein.lan.stwcx.xyz> <20200420205325.GA1693@ninjato> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vmttodhTwj0NAgWp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --vmttodhTwj0NAgWp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Yes, it might be easiest if he merges your patch (with attribution) into > > the else branch of his fw-load patch. > >=20 >=20 > OK, so to summarize, I should update my patch to use > device_property_read_string() instead and also init the memory to 0XFF if= no > file is present. And change name of the function to Or something else went wrong. > i2c_slave_init_eeprom_data. Yes, that is my idea. You also need to replace checking for an of_node with some equivalent for device properties maybe, but that should be easy to find out. > I will look into that and let you know once I'm done. Thank you! --vmttodhTwj0NAgWp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl6e5DcACgkQFA3kzBSg KbbQDBAArMsUqUxWgqSrbwcIRt/Gr1cw3ADl+WmjfVx86o4L2zXR6pxtLqd3XZlw ETCYwyuI3wd1o67wtJTES/XurkgGa1QjgKuLEkbPW/G5dU+A9bDdjYbiJfzFJZmb N45BlhIjEa4mf9d6r7387sGtApMkjQhsTWQxjn1tuzPvzvB26ntJ6q7hM+M5JldV 1JYwin5YkcgvuFp4cECIO92jyvvupIWtJTxMaMlsHJFeicLWKPaXI/We7vC4W7Z9 aAZmc5NNrpNiT2ffkR4sGveVT2D0KckPHPsgoEWP+1FI3QrV72NAo6gTxbuJKbcp dlDDIGt8f5nU/ubUG21zy0RzWraX+pzXd+/bOkh5H9jeY7Z4VjBCepbEj+ekn6eX 4GpVNz2Eav3+N8aCRWcv8bwW9U5ww/cQoOlkjh+aI3AIlwOXzG24IC3LLXyjtTt1 xXDNOubCHZa3RGcmfduhEue25trD/+05kxcFe5zvEC4c6JP9GaiQC2w4f6FtJmHf pOzGKkowDO3rV8OpBqyyWTSjELG/icW/yOGFbqe1haP0akor3eiad8aiGFfwvMkA CDm/h0S6NWR7XYpLTwYy1/TyjTpX+d9fqAiPOROrc4T/LzNUjfLNkvwvLjAiqXUJ UxWdgMA26T+ui1/dZi6XcWt+sZs5r4DUjbEWJZVXCM+NmdHTZ+o= =jvL2 -----END PGP SIGNATURE----- --vmttodhTwj0NAgWp--