From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A75C54FD0 for ; Mon, 27 Apr 2020 10:39:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B10C620575 for ; Mon, 27 Apr 2020 10:39:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbgD0Ki5 convert rfc822-to-8bit (ORCPT ); Mon, 27 Apr 2020 06:38:57 -0400 Received: from sauhun.de ([88.99.104.3]:56640 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbgD0Kiy (ORCPT ); Mon, 27 Apr 2020 06:38:54 -0400 Received: from localhost (p54B330D3.dip0.t-ipconnect.de [84.179.48.211]) by pokefinder.org (Postfix) with ESMTPSA id 30E9C2C1F66; Mon, 27 Apr 2020 12:38:52 +0200 (CEST) Date: Mon, 27 Apr 2020 12:38:52 +0200 From: Wolfram Sang To: Dmitry Osipenko Cc: Thierry Reding , Jon Hunter , Laxman Dewangan , Manikanta Maddireddy , Vidya Sagar , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time Message-ID: <20200427103851.GB24446@kunai> References: <77a31b2f-f525-ba9e-f1ae-2b474465bde4@gmail.com> <470b4de4-e98a-1bdc-049e-6259ad603507@nvidia.com> <79f6560e-dbb5-0ae1-49f8-cf1cd95396ec@nvidia.com> <20200427074837.GC3451400@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Apr 27, 2020 at 12:52:10PM +0300, Dmitry Osipenko wrote: > 27.04.2020 10:48, Thierry Reding пишет: > ... > >> Maybe but all these other problems appear to have existed for sometime > >> now. We need to fix all, but for the moment we need to figure out what's > >> best for v5.7. > > > > To me it doesn't sound like we have a good handle on what exactly is > > going on here and we're mostly just poking around. > > > > And even if things weren't working quite properly before, it sounds to > > me like this patch actually made things worse. > > There is a plenty of time to work on the proper fix now. To me it sounds > like you're giving up on fixing the root of the problem, sorry. >From what I understood, there were (at least) two regressions reported. So, to me, it makes sense to revert the change, so for upstream users everything stays "the same". Of course, this does not mean it should stay like this forever and you guys can work on fixing the root causes. I'll happily apply them for this release when you are confident with the results.