From: Wolfram Sang <wsa@the-dreams.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Manikanta Maddireddy <mmaddireddy@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time
Date: Mon, 27 Apr 2020 17:31:07 +0200 [thread overview]
Message-ID: <20200427153106.GA8113@kunai> (raw)
In-Reply-To: <20200427141922.GD3464906@ulmo>
[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]
> Yes, that bug should be fixed anyway. But that doesn't justify breaking
> suspend/resume completely, which *is* a regression.
>
> Look, I'm not saying that we should drop this patch altogether. All I'm
> saying is that we should postpone it so that we can: a) get suspend and
> resume working again (and by doing so make sure no other suspend/resume
> regressions silently creep in, because that always seems to happen when
> you're not looking) and b) fix any preexisting issues without possibly
> scrambling the result with this perhaps unrelated fix.
>
> So, again, I think the safest road forward is to back this one out for
> now, fix whatever this other bug is and once suspend/resume is working
> properly again we can revisit this patch based on a known-good baseline.
I am with you here. I want to add that the proper fix should be
developed without thinking too much about stable in the first place.
*When* we have a proper working fix, then we can think about making it
"more" suitable for backporting. Yet, it may also be a result that older
kernels need a different solution. Or have no solution at all, in case
they can't do atomic_transfers and this is needed.
D'accord?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-27 15:31 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 19:12 [PATCH v2 0/2] NVIDIA Tegra I2C synchronization correction Dmitry Osipenko
2020-03-24 19:12 ` [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time Dmitry Osipenko
2020-04-15 16:31 ` Wolfram Sang
2020-04-20 19:53 ` Jon Hunter
2020-04-20 22:11 ` Dmitry Osipenko
2020-04-21 0:32 ` Dmitry Osipenko
2020-04-21 9:49 ` Jon Hunter
2020-04-21 12:39 ` Manikanta Maddireddy
2020-04-21 13:08 ` Jon Hunter
2020-04-21 13:49 ` Manikanta Maddireddy
2020-04-21 13:25 ` Dmitry Osipenko
2020-04-21 14:40 ` Jon Hunter
2020-04-21 15:08 ` Dmitry Osipenko
2020-04-21 19:42 ` Jon Hunter
2020-04-22 13:40 ` Dmitry Osipenko
2020-04-22 13:59 ` Jon Hunter
2020-04-22 14:07 ` Dmitry Osipenko
2020-04-23 10:56 ` Jon Hunter
2020-04-23 16:33 ` Dmitry Osipenko
2020-04-24 7:10 ` Jon Hunter
2020-04-24 14:45 ` Dmitry Osipenko
2020-04-24 15:19 ` Jon Hunter
2020-04-27 7:48 ` Thierry Reding
2020-04-27 8:44 ` Wolfram Sang
2020-04-27 9:07 ` Dmitry Osipenko
2020-04-27 10:35 ` Wolfram Sang
2020-04-27 10:50 ` Thierry Reding
2020-04-27 15:32 ` Thierry Reding
2020-04-27 16:02 ` Dmitry Osipenko
2020-04-27 10:49 ` Thierry Reding
2020-04-27 9:52 ` Dmitry Osipenko
2020-04-27 10:38 ` Wolfram Sang
2020-04-27 13:15 ` Dmitry Osipenko
2020-04-27 14:19 ` Thierry Reding
2020-04-27 15:31 ` Wolfram Sang [this message]
2020-05-02 14:40 ` Dmitry Osipenko
2020-05-02 14:43 ` Wolfram Sang
2020-05-04 15:42 ` Thierry Reding
2020-05-04 20:55 ` Dmitry Osipenko
2020-04-27 11:00 ` Thierry Reding
2020-04-27 14:21 ` Dmitry Osipenko
2020-04-27 15:12 ` Thierry Reding
2020-04-27 15:18 ` Dmitry Osipenko
2020-04-28 8:01 ` Jon Hunter
2020-04-28 12:37 ` Dmitry Osipenko
2020-04-29 8:14 ` Thierry Reding
2020-04-29 8:55 ` Thierry Reding
2020-04-29 12:35 ` Dmitry Osipenko
2020-04-29 13:57 ` Jon Hunter
2020-04-29 14:46 ` Dmitry Osipenko
2020-04-29 16:24 ` Thierry Reding
2020-04-29 17:02 ` Dmitry Osipenko
2020-04-29 16:30 ` Thierry Reding
2020-04-29 16:54 ` Dmitry Osipenko
2020-04-29 17:34 ` Dmitry Osipenko
2020-04-27 12:46 ` Dmitry Osipenko
2020-04-27 14:13 ` Dmitry Osipenko
2020-04-27 14:45 ` Dmitry Osipenko
2020-04-27 15:38 ` Dmitry Osipenko
2020-04-28 8:02 ` Jon Hunter
2020-04-28 23:12 ` Dmitry Osipenko
2020-04-21 15:18 ` Dmitry Osipenko
2020-04-21 15:34 ` Jon Hunter
2020-04-21 19:07 ` Dmitry Osipenko
2020-04-28 13:43 ` Dmitry Osipenko
2020-03-24 19:12 ` [PATCH v2 2/2] i2c: tegra: Synchronize DMA before termination Dmitry Osipenko
2020-04-15 16:31 ` Wolfram Sang
2020-04-15 11:45 ` [PATCH v2 0/2] NVIDIA Tegra I2C synchronization correction Wolfram Sang
2020-04-15 14:14 ` Dmitry Osipenko
2020-04-15 16:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427153106.GA8113@kunai \
--to=wsa@the-dreams.de \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).