From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24651C83000 for ; Tue, 28 Apr 2020 22:09:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC7E8206D6 for ; Tue, 28 Apr 2020 22:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbgD1WJG (ORCPT ); Tue, 28 Apr 2020 18:09:06 -0400 Received: from sauhun.de ([88.99.104.3]:47642 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbgD1WJG (ORCPT ); Tue, 28 Apr 2020 18:09:06 -0400 Received: from localhost (p5486CA03.dip0.t-ipconnect.de [84.134.202.3]) by pokefinder.org (Postfix) with ESMTPSA id 52F2A2C0710; Wed, 29 Apr 2020 00:09:04 +0200 (CEST) Date: Wed, 29 Apr 2020 00:09:04 +0200 From: Wolfram Sang To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Stefan Wahren , Kamal Dasu , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFT] i2c: brcmstb: properly check NACK condition Message-ID: <20200428220904.GB7698@kunai> References: <20200426081211.10876-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: <20200426081211.10876-1-wsa+renesas@sang-engineering.com> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 26, 2020 at 10:12:10AM +0200, Wolfram Sang wrote: > From: Wolfram Sang >=20 > cppcheck rightfully complains about: >=20 > drivers/i2c/busses/i2c-brcmstb.c:319:7: warning: Condition 'CMD_RD' is al= ways true [knownConditionTrueFalse] > drivers/i2c/busses/i2c-brcmstb.c:319:17: warning: Condition 'CMD_WR' is a= lways false [knownConditionTrueFalse] > if ((CMD_RD || CMD_WR) && >=20 > Compare the values to the 'cmd' variable. >=20 > Fixes: dd1aa2524bc5 ("i2c: brcmstb: Add Broadcom settop SoC i2c controlle= r driver") > Signed-off-by: Wolfram Sang Applied to for-current, thanks! --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl6oqX8ACgkQFA3kzBSg KbYq7Q/7Br16/++9ebjOhm70GQ8PM9ZFe3yeQh+WXJPb+pwCvOvnwRnFg+dn6Kg3 RPpLJF1PDwS+HJsLrKZGqRyLhtuWY2N2WTbN04SoQaxC71+T7Nv/R63U0m9FpaKM U0PmwmOZ2KL8+1/HmzhlCdD8tnbI8udU3FbPEjdgo4DM7fWy2kAy8Ar1AlLfECJr sIBSpKw5+0pYAJA1MaFMHMbXZpl01qPEsEpMVgbalXifBxZs/+nZJmRSGQny8Euv IxcdCovHhLGfSewgOGB/jQRZo4GzcyZr+2jnyA3wsiDvCip+z/RUzgpPHPjvVJ8i qo65Ep++nU2yTgxS+QCb+iPsEYm0B+cD7xnd+Up/XPi6OZseCKjwLBSbruR7v5JF m38GSUvBQxapp6FBL2L8E5K8X3jLDAeSdwQ6vH86fardMbh1plXXiR9SRhVLJXpw FKo7QWMHEnTTqZ8xmGv2KFcTR8ZCFgDFAMx8nZ2UBCEbT4GSD8AD1spd4wWpJCob rLbXuvKbmniIrYYoHDFfTL7NhP5y1akeka/h97KF7n9NwSV81KsnmXysOoT3EPBn R49VS65VjGdieBHrJI9BBfU0hLtcKDYsI0KUA/cyINqz403XSThLtGA5RJM3fHPJ 3mCvMgj+wiLa8kS8p4VUCAzi6Zj1a5VvQEDgV7QpgUgOUBf5Kis= =GdAJ -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50--