From: Alain Volmat <alain.volmat@st.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<linux-i2c@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<kernel-janitors@vger.kernel.org>, <wsa@the-dreams.de>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: stm32f7: prevent array underflow in stm32f7_get_lower_rate()
Date: Wed, 29 Apr 2020 16:15:13 +0200 [thread overview]
Message-ID: <20200429141513.GB31498@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <20200429132323.GB815283@mwanda>
Hi Dan,
indeed, thanks a lot.
Reviewed-by: Alain Volmat <alain.volmat@st.com>
Alain
On Wed, Apr 29, 2020 at 04:23:23PM +0300, Dan Carpenter wrote:
> We want to break with "i" set to zero whether we find the rate we want
> or not. In the current code, if we don't find the rate we want then it
> exits the loop with "i" set to -1 and results in an array underflow.
>
> Fixes: 09cc9a3bce91 ("i2c: stm32f7: allows for any bus frequency")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 9c9e10ea91991..bff3479fe122a 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -607,7 +607,7 @@ static u32 stm32f7_get_lower_rate(u32 rate)
> {
> int i = ARRAY_SIZE(stm32f7_i2c_specs);
>
> - while (i--)
> + while (--i)
> if (stm32f7_i2c_specs[i].rate < rate)
> break;
>
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-04-29 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 13:23 [PATCH] i2c: stm32f7: prevent array underflow in stm32f7_get_lower_rate() Dan Carpenter
2020-04-29 14:15 ` Alain Volmat [this message]
2020-04-30 14:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429141513.GB31498@gnbcxd0016.gnb.st.com \
--to=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox